No data saved in the partial view![Answered] RSS

9 replies

Last post Feb 11, 2019 02:48 AM by Xing Zou

‹ Previous Thread|Next Thread ›

Shortcuts

Related Links

musbah7@hotm...

Member

62 Points

180 Posts

No data saved in the partial view!

Feb 01, 2019 07:21 AM|musbah7@hotmail.com|LINK

I'm trying to save data updated on the partial view called in Edit action.

I have these models:

Nz Class:

using System;
using System.Collections.Generic;
using System.ComponentModel.DataAnnotations;

namespace NozCoreWebApp5.Models
{
    public partial class Nz
    {
        public Nz()
        {
            Mkh = new HashSet<Mkh>();
        }
        [DisplayFormat(ApplyFormatInEditMode = true, DataFormatString = "{0:#########}")]
        public decimal TxtId { get; set; }
        public int Sn { get; set; }
        public string FullName { get; set; }
        [DisplayFormat(ApplyFormatInEditMode = true, DataFormatString = "{0:yyyy-MM-dd}")]
        public DateTime? BirthDate { get; set; }
        public int SexCode { get; set; }
        public string InsertUser { get; set; }
        [DisplayFormat(ApplyFormatInEditMode = true, DataFormatString = "{0:yyyy-MM-dd}")]
        public DateTime InsertDate { get; set; }

        public ICollection<Mkh> Mkh { get; set; }
    }
}

Mkh Class: (child for Nz)

using System;
using System.Collections.Generic;
using System.ComponentModel.DataAnnotations;

namespace NozCoreWebApp5.Models
{
    public partial class Mkh
    {
        public int Sn { get; set; }
        public decimal TxtId { get; set; }
        public int MkhCode { get; set; }
        [DisplayFormat(ApplyFormatInEditMode = true, DataFormatString = "{0:yyyy-MM-dd}")]
        public DateTime MkhDate { get; set; }
        public int Days { get; set; }
        public string Notes { get; set; }
        public string InsertUser { get; set; }
        [DisplayFormat(ApplyFormatInEditMode = true, DataFormatString = "{0:yyyy-MM-dd}")]
        public DateTime InsertDate { get; set; }


        public MkhType MkhCodeNavigation { get; set; }
        public Nz Txt { get; set; }
    }
}

MkhType Calss: (Parent of Mkh)

using System;
using System.Collections.Generic;

namespace NozCoreWebApp5.Models
{
    public partial class MkhType
    {
        public MkhType()
        {
            Mkh = new HashSet<Mkh>();
        }

        public int MkhCode { get; set; }
        public string MkhName { get; set; }
        public string InsertUser { get; set; }
        public DateTime InsertDate { get; set; }

        public ICollection<Mkh> Mkh { get; set; }
    }
}

and I have this context:

using System;
using Microsoft.EntityFrameworkCore;
using Microsoft.EntityFrameworkCore.Metadata;

namespace NozCoreWebApp5.Models
{
    public partial class NozContext : DbContext
    {
        public NozContext()
        {
        }

        public NozContext(DbContextOptions<NozContext> options)
            : base(options)
        {
        }

        public virtual DbSet<Mkh> Mkh { get; set; }
        public virtual DbSet<MkhType> MkhType { get; set; }
        public virtual DbSet<Nz> Nz { get; set; }
        public virtual DbSet<Sex> Sex { get; set; }

        protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
        {
            if (!optionsBuilder.IsConfigured)
            {
#warning To protect potentially sensitive information in your connection string, you should move it out of source code. See http://go.microsoft.com/fwlink/?LinkId=723263 for guidance on storing connection strings.
                optionsBuilder.UseSqlServer("Server=My-PC\\SQLEXPRESS;Database=Noz;Trusted_Connection=True;");
            }
        }

        protected override void OnModelCreating(ModelBuilder modelBuilder)
        {

            modelBuilder.Entity<Mkh>(entity =>
            {
                entity.HasKey(e => e.Sn);

                entity.ToTable("Mkh");

                entity.Property(e => e.Sn).HasColumnName("sn");

                entity.Property(e => e.Days).HasColumnName("days");

                entity.Property(e => e.InsertDate)
                    .HasColumnName("insert_date")
                    .HasColumnType("datetime")
                    .HasDefaultValueSql("(getdate())");

                entity.Property(e => e.InsertUser)
                    .IsRequired()
                    .HasColumnName("insert_user")
                    .HasMaxLength(20)
                    .HasDefaultValueSql("(N'any')");

                entity.Property(e => e.MkhCode).HasColumnName("Mkh_code");

                entity.Property(e => e.MkhDate)
                    .HasColumnName("Mkh_date")
                    .HasColumnType("date");

                entity.Property(e => e.Notes).HasColumnName("notes");

                entity.Property(e => e.TxtId)
                    .HasColumnName("txt_id")
                    .HasColumnType("numeric(9, 0)");

                entity.HasOne(d => d.MkhCodeNavigation)
                    .WithMany(p => p.Mkh)
                    .HasForeignKey(d => d.MkhCode)
                    .OnDelete(DeleteBehavior.ClientSetNull)
                    .HasConstraintName("FK_Mkh_Mkh_type");

                entity.HasOne(d => d.Txt)
                    .WithMany(p => p.Mkh)
                    .HasForeignKey(d => d.TxtId)
                    .OnDelete(DeleteBehavior.ClientSetNull)
                    .HasConstraintName("FK_Mkh_Nz");
            });

            modelBuilder.Entity<MkhType>(entity =>
            {
                entity.HasKey(e => e.MkhCode);

                entity.ToTable("Mkh_type");

                entity.Property(e => e.MkhCode).HasColumnName("Mkh_code");

                entity.Property(e => e.InsertDate)
                    .HasColumnName("insert_date")
                    .HasColumnType("datetime")
                    .HasDefaultValueSql("(getdate())");

                entity.Property(e => e.InsertUser)
                    .IsRequired()
                    .HasColumnName("insert_user")
                    .HasMaxLength(20)
                    .HasDefaultValueSql("(N'any')");

                entity.Property(e => e.MkhName)
                    .IsRequired()
                    .HasColumnName("Mkh_name")
                    .HasMaxLength(50);
            });

            modelBuilder.Entity<Nz>(entity =>
            {
                entity.HasKey(e => e.TxtId);

                entity.ToTable("Nz");

                entity.Property(e => e.TxtId)
                    .HasColumnName("txt_id")
                    .HasColumnType("numeric(9, 0)");

                entity.Property(e => e.BirthDate)
                    .HasColumnName("birth_date")
                    .HasColumnType("date");


                entity.Property(e => e.InsertDate)
                    .HasColumnName("insert_date")
                    .HasColumnType("datetime")
                    .HasDefaultValueSql("(getdate())");

                entity.Property(e => e.InsertUser)
                    .IsRequired()
                    .HasColumnName("insert_user")
                    .HasMaxLength(20)
                    .HasDefaultValueSql("(N'any')");

                entity.Property(e => e.SexCode).HasColumnName("sex_code");

                entity.Property(e => e.Sn)
                    .HasColumnName("sn")
                    .ValueGeneratedOnAdd();

                entity.HasOne(d => d.SexCodeNavigation)
                    .WithMany(p => p.Nz)
                    .HasForeignKey(d => d.SexCode)
                    .OnDelete(DeleteBehavior.ClientSetNull)
                    .HasConstraintName("FK_Nz_sex");
            });

            modelBuilder.Entity<Sex>(entity =>
            {
                entity.HasKey(e => e.SexCode);

                entity.ToTable("sex");

                entity.Property(e => e.SexCode).HasColumnName("sex_code");

                entity.Property(e => e.SexName)
                    .IsRequired()
                    .HasColumnName("sex_name")
                    .HasMaxLength(10);
            });

            modelBuilder.Entity<Nz>()
            .HasAlternateKey(x => x.Sn).HasName("IX_Sn");
        }
    }
}

and the NzController actions:

    public class NzController : Controller
    {
        private readonly NozContext _context;

        public NzController(NozContext context)
        {
            _context = context;
        }
// ........ Some Code here .............
public async Task<IActionResult> Edit(decimal? id)
        {
            if (id == null)
            {
                return NotFound();
            }

            //var Nz = await _context.Nz.FindAsync(id);
            var Nz = await _context.Nz
                         .Include(n => n.Mkh)
                         .ThenInclude(m => m.MkhCodeNavigation)
                         .FirstOrDefaultAsync(n => n.TxtId == id.Value);
            if (Nz == null)
            {
                return NotFound();
            }
            ViewData["SexCode"] = new SelectList(_context.Sex, "SexCode", "SexName", Nz.SexCode);
            return View(Nz);
        }

        [HttpPost]
        [ValidateAntiForgeryToken]
        public async Task<IActionResult> Edit(decimal id, [Bind("TxtId,Sn,FullName,BirthDate,SexCode,InsertUser,InsertDate")] Nz Nz)
        {
            if (id != Nz.TxtId)
            {
                return NotFound();
            }

            if (ModelState.IsValid)
            {
                try
                {
                    var Edited = new Nz()
                    {
                        TxtId = Nz.TxtId,
                        BirthDate = Nz.BirthDate,
                        InsertDate = Nz.InsertDate,
                        InsertUser = Nz.InsertUser,
                        FullName = Nz.FullName,
                        SexCode = Nz.SexCode,
                        Mkh = Nz.Mkh.Where(m => m.TxtId == Nz.TxtId).ToList(),
                    };
                    _context.Update(Edited);
                    await _context.SaveChangesAsync();
                }
                catch (DbUpdateConcurrencyException)
                {
                    if (!NzExists(Nz.TxtId))
                    {
                        return NotFound();
                    }
                    else
                    {
                        throw;
                    }
                }
                return RedirectToAction(nameof(Index));
            }
            ViewData["SexCode"] = new SelectList(_context.Sex, "SexCode", "SexName", Nz.SexCode);
            return View(Nz);
        }

the partial view 'EditNz' in Mkh controller:

@model IEnumerable<Mkh>

<h4>MkhTbl</h4>
<hr />
    <table class="table">
        <thead>
            <tr>
                <th>
                    Date
                </th>
                <th>
                    Days
                </th>
                <th>
                    Notes
                </th>
                <th>
                    Mkh Type
                </th>
                <th></th>
            </tr>
        </thead>
        <tbody>
            @foreach (var item in Model)
            {

                <tr>
                    <td> 
                        @Html.EditorFor(modelItem => item.MkhDate)
                    </td>
                    <td>
                        @Html.EditorFor(modelItem => item.Days)
                    </td>
                    <td>
                        @Html.EditorFor(modelItem => item.Notes)
                    </td>
                    <td>
                        @Html.EditorFor(modelItem => item.MkhCodeNavigation.MkhName)
                    </td>
                </tr>
            }
        </tbody>
    </table>

    @section Scripts {
        @{await Html.RenderPartialAsync("_ValidationScriptsPartial");}
    }

and the calling of the previous partial in Edit view in NzController:

@{ await Html.RenderPartialAsync("~/Views/Mkh/EditNz.cshtml", Model.Mkh); }

Now when I press save button (submit) no data is saved for the partial one like days! Why? and How to solve please?

and How to return Select with returned values from MkhType? (using MkhCodeNavigation I think)

- Reply
yogyogi
Participant

1253 Points

936 Posts

Re: No data saved in the partial view!

Feb 01, 2019 05:32 PM|yogyogi|LINK

It will be better if you put a breakpoint in visual studio and then try to find out which line you get an error.

Once you get the error then provide it this post. This will help you get accurate to the point answers.

Regards

Helping you always. Don't forget to click "Mark as Answer" on the post that helped you.
♠ ASP.NET Core Tutorials → Start from the Beginning and become an Expert in 30 days time ♠

bruce (sqlwo...

All-Star

58254 Points

15674 Posts

Re: No data saved in the partial view!

Feb 01, 2019 07:03 PM|bruce (sqlwork.com)|LINK

the binding names are not correct for the partial.

the easiest fix is change the partial model type to NZ and the loop

           @for(var i=0 i < Model.Mkh.Count, ++i)
            {

                <tr>
                    <td> 
                        @Html.EditorFor(m => m.Mkh[i].MkhDate)
                    </td>
                    <td>
                        @Html.EditorFor(m => m.Mkh[i].Days)
                    </td>
                    <td>
                        @Html.EditorFor(m => m.Mkh[i].Notes)
                    </td>
                    <td>
                        @Html.EditorFor(m => m.Mkh[i].MkhCodeNavigation.MkhName)
                    </td>
                </tr>
            }

you could define an interface:

public interface IMkh
{
   public ICollection<Mkh> Mkh { get; set; }
}

have the model implement, and the view use. then the partial could be used with different models.

bruce (sqlwork.com)

- Reply
musbah7@hotm...
Member

62 Points

180 Posts
Re: No data saved in the partial view!

Feb 02, 2019 04:26 AM|musbah7@hotmail.com|LINK
Thanks

Do you mean change the partial model type to:
```
@model IEnumerable<Nz>
```
about the loop I think it should be like this:
```
@for(var i=0; i < Model.Mkh.Count; ++i)
```
but it doesn't recognize 'Mkh' in the loop I think because the interface haven't been defined correctly right?

where should I define the interface? in Nz model? and in that case it gives an error if I put 'public' for the 'ICollection': 'The modifier 'public' is not valid for this item'

then should I do anything in startup to register this interface?
- Reply
bruce (sqlwo...
All-Star

58254 Points

15674 Posts

Re: No data saved in the partial view!

Feb 02, 2019 04:59 PM|bruce (sqlwork.com)|LINK
No it should be:

@model Nz

bruce (sqlwork.com)

musbah7@hotm...

Member

62 Points

180 Posts

Re: No data saved in the partial view!

Feb 03, 2019 02:17 AM|musbah7@hotmail.com|LINK

Thanks

let me show you what I have for your suggestion. at the Nz model:

 public ICollection<Mkh> Mkh { get; set; }
 // ... Some code here
 public interface IMkh 
 { 
    ICollection<Mkh> Mkh { get; set; } 
 }

and for the view

@model Nz
 @*Some code here*@ 
            @for (var i = 0; i < Model.Mkh.Count; ++i)
            {

                <tr>
                    <td>
                        @Html.EditorFor(m => m.Mkh[i].MkhDate)
                    </td>
                    <td>
                        @Html.EditorFor(m => m.Mkh[i].Days)
                    </td>
                    <td>
                        @Html.EditorFor(m => m.Mkh[i].Notes)
                    </td>
                    <td>
                        @Html.EditorFor(m => m.Mkh[i].MkhCodeNavigation.MkhaName)
                    </td>
                </tr>
            }

But m.Mkh[i] in the EditorFor gives me an error: cannot apply indexing with [] to an expression of type 'ICollection<Mkh>'

- Reply
bruce (sqlwo...
All-Star

58254 Points

15674 Posts

Re: No data saved in the partial view!

Feb 03, 2019 07:19 PM|bruce (sqlwork.com)|LINK
You really want indexing for binding, so use IList, instead of ICollection.

bruce (sqlwork.com)

Xing Zou

Contributor

2253 Points

735 Posts

Re: No data saved in the partial view!

Feb 04, 2019 04:53 AM|Xing Zou|LINK

Hi musbah7,

Use Bruce's suggestion and you need to use IList<> instead of iCollection<>.

public partial class Nz
    {
        public Nz()
        {
            //Mkh = new HashSet<Mkh>();
        }
        ...

        public IList<Mkh> Mkh { get; set; }
    }

Pass model to partial view directly:

 <form asp-action="Edit">
            <div asp-validation-summary="ModelOnly" class="text-danger"></div>
            <input type="hidden" asp-for="TxtId" />
           //...
           
            <div class="form-group">
                @{ await Html.RenderPartialAsync("~/Views/Mkh/EditNz.cshtml", Model); }
            </div>
            <div class="form-group">
                <input type="submit" value="Save" class="btn btn-primary" />
            </div>
        </form>

You also need to pass all data of Mkh use @Html.HiddenFor if you do not want to show them on view. Otherwise, the field would be null and the dateTime would be {1/1/0001 12:00:00 AM} caused below error

SqlTypeException: SqlDateTime overflow. Must be between 1/1/1753 12:00:00 AM and 12/31/9999 11:59:59 PM

So, you could always add breakpoints on you action to check Nz ( if dateTime field has incorrect date or other data error) when you submit the form.

Partial View EditNz.cshtml:

@model Nz

<h4>MkhTbl</h4>
<hr />
<table class="table">
    <thead>
        <tr>
            <th>
                Date
            </th>
            <th>
                Days
            </th>
            <th>
                Notes
            </th>
            <th>
                Mkh Type
            </th>
            <th></th>
        </tr>
    </thead>
    <tbody>
        @for (var i = 0; i < Model.Mkh.Count; ++i)
        {

        <tr>
            @Html.HiddenFor(m => m.Mkh[i].Sn)
            @Html.HiddenFor(m => m.Mkh[i].TxtId)
            @Html.HiddenFor(m => m.Mkh[i].InsertDate)
            @Html.HiddenFor(m => m.Mkh[i].InsertUser)
            @Html.HiddenFor(m => m.Mkh[i].MkhCode)
            <td>
                @Html.EditorFor(m => m.Mkh[i].MkhDate)
            </td>
            <td>
                @Html.EditorFor(m => m.Mkh[i].Days)
            </td>
            <td>
                @Html.EditorFor(m => m.Mkh[i].Notes)
            </td>
            <td>
                @Html.HiddenFor(m => m.Mkh[i].MkhCodeNavigation.MkhCode)
                @Html.HiddenFor(m => m.Mkh[i].MkhCodeNavigation.InsertUser)
                @Html.EditorFor(m => m.Mkh[i].MkhCodeNavigation.MkhName)
            </td>
        </tr>
        } 
    </tbody>
</table>

@section Scripts {
    @{await Html.RenderPartialAsync("_ValidationScriptsPartial");}
}

Besides. you need to bind Mkh on edit action of NzController:

[HttpPost]
[ValidateAntiForgeryToken]
public async Task<IActionResult> Edit(decimal id, [Bind("TxtId,Sn,FullName,BirthDate,SexCode,InsertUser,InsertDate,Mkh")]  Nz Nz)
        {
            if (id != Nz.TxtId)
            {
                return NotFound();
            }

            if (ModelState.IsValid)
            {
                try
                {                
                    _context.Update(Nz);
                    await _context.SaveChangesAsync();
                }
                catch (DbUpdateConcurrencyException)
                {
                    if (!NzExists(Nz.TxtId))
                    {
                        return NotFound();
                    }
                    else
                    {
                        throw;
                    }
                }
                return RedirectToAction(nameof(Index));
            }
            
            return View(Nz);
        }

This enables you to Edit the partial view data and save the changes.

Xing

Learning Always

- Reply
musbah7@hotm...
Member

62 Points

180 Posts
Re: No data saved in the partial view!

Feb 04, 2019 09:58 AM|musbah7@hotmail.com|LINK
Thanks

before updating the suggested solution I solved the 'SqlTypeException: SqlDateTime overflow. Must be between 1/1/1753 12:00:00 AM and 12/31/9999 11:59:59 PM' error by adding the item 'InsertDate' to the controller:
```
                    var Edited = new Nz()
                    {
                        TxtId = nzeel.TxtId,
                        BirthDate = nzeel.BirthDate,
                        InsertDate = nzeel.InsertDate,
```
for the suggested solution:

I removed this from Nz model, Am I right? (because we replaced it with the IList one)
```
public ICollection<Mkh> Mkh { get; set; }
```
Then of course I defined the Mkh IList, therefore every thing of 'Mkh' in the context or controller will be connected to the IList.

Then I did every thing you mention. I added every item defined in 'Mkh' model to the partial and some of them are hidden:
```
                @Html.HiddenFor(m => m.Mkh[i].Sn)
                @Html.HiddenFor(m => m.Mkh[i].TxtId)
                @Html.HiddenFor(m => m.Mkh[i].InsertDate)
                @Html.HiddenFor(m => m.Mkh[i].UpdateDate)
                @Html.HiddenFor(m => m.Mkh[i].InsertUser)
                @Html.HiddenFor(m => m.Mkh[i].UpdateUser)
                @Html.HiddenFor(m => m.Mkh[i].MkhCode)
                @Html.HiddenFor(m => m.Mkh[i].Txt)
```
The 'UpdateUser' and 'UpdateDate' are defined in 'Mkh' model as:
```
        public string UpdateUser { get; set; }
        public DateTime? UpdateDate { get; set; }
```
which means 'updatedate' can be null, despite that I put it as hidden in the partial.

despite passing all items of 'Mkh' model to the partial when I press save the annoying error comes again:

SqlTypeException: SqlDateTime overflow. Must be between 1/1/1753 12:00:00 AM and 12/31/9999 11:59:59 PM.

How to solve please?

another matter how to return 'Select' values for the 'MkhCode' item from 'MkhType' in the partial? not only the returned value.
- Reply
Xing Zou
Contributor

2253 Points

735 Posts
Re: No data saved in the partial view!

Feb 11, 2019 02:48 AM|Xing Zou|LINK
Hi musbah7,

You need to change ICollection to IList.

Have you ever tired to add breakpoints on the Edit action to check the data( especially all DateTime field) when you submit the form? The error occurs while some of these field have incorrect data.

musbah7@hotmail.com
another matter how to return 'Select' values for the 'MkhCode' item from 'MkhType' in the partial? not only the returned value.

You need to use ViewBag/ViewData in Edit (Get) action and use DropDownList in the partial view EditNz.cshtml:
```
 ViewData["MkhName"] = new SelectList(_context.MkhType, "MkhName", "MkhName");
```
```
<select asp-for="Mkh[i].MkhCodeNavigation.MkhName" asp-items="@ViewBag.MkhName"> </select>
or
@Html.DropDownListFor(m => m.Mkh[i].MkhCodeNavigation.MkhName, (SelectList)ViewBag.MkhName)
```
For all SelecList usage, refer to below link of Razor Pages which is similar to MVC, just use it in action and use ViewData["MkhName"] apparently.

https://www.learnrazorpages.com/razor-pages/tag-helpers/select-tag-helper

Xing
Learning Always

‹ Previous Thread|Next Thread ›