Hi, i have a form that i am trying to use some javascript to validate the items on the client side to keep things quick for the user. I am also using master pages. I can not seem to get the javascript to work with anything on the page. if i add it to the OnClientClick it does not work. I have never done this before and was wondering if anybody could help me out. Thanks.

Can you be more specific about what the Javascript is being used for? There may be inherit web controls that will do what you need for you.

There may be controls that do that but that is not what i am asking, i am checking a textbox to make sure that there is a number in the box that is between the numbers that i specify. I am trying to learn some javascript for some client side scripting and would like to be able to understand how the things are working. Thanks

kashwmu:

There may be controls that do that but that is not what i am asking, i am checking a textbox to make sure that there is a number in the box that is between the numbers that i specify. I am trying to learn some javascript for some client side scripting and would like to be able to understand how the things are working. Thanks

Okay, would you mind posting the code you have so far?

Your problem is probably with the IDs of the controls. A content holder (like a Master Page) mangles the ID of the control like content-holder-ID + "_" + control-ID which means OnClientClick('control-ID') won't work. Changing to OnClientClick('<%= control-ID.ClientID %>') will usually fix the problem.

NC...

To me it seems very simple but it is still not working right, i got it to do some of the stuff but here is the code.

if (!min) {min = 0}

How are you calling validateNumber(field, msg, min, max) and from what type of element? Give an example.

NC...

Sorry about not including that, my bad.

I have tried from the main form with a submit and as of right now i am just trying to use a button until i can get it to work.

<asp:Button ID="Button1" runat="server" Text="Button" OnClientClick="return validateNumber(this.txtshift,'This Works',1,3);" UseSubmitBehavior="False" />

Thanks

When calling the validateNumber function this way
     OnClientClick="return validateNumber(this.txtshift,'This Works',1,3);"
this.txtshift does not refer to a TextBox txtshift, it refers instead to a property of the Button named txtshift.

Try it this way:
     1. Remove the OnClientClick event handler from the Designer (HTML view).
          <asp:Button ID="Button1" runat="server" Text="Button" UseSubmitBehavior="False" />
     2. In the CodeBehind, Page_Load event handler, add this:
          Button1.OnClientClick = "return validateNumber('" + txtshift.ClientID + "','This Works',1,3);"
     3. Change your function as follows:

function validateNumber(fieldId, msg, min, max)
{
 var field = document.GetElementById(fieldId);

 if (!min)
 {
  min = 0;
 }

 if (!max)
 {
  max = 255;
 }

 if ( (parseInt(field.value) != field.value) || field.value.length < min || field.value.length > max )
 {
  alert(msg);
  field.focus();
  field.select();

  return false;
 }

 return true;
}

NC...