How do I use Windsor as IoC?

How do I use Castle:Windsor as IoC.. I've tried doing the following:

public static void Start()
        {
            Container.Register(Component.For<IHttpControllerFactory>().ImplementedBy<CustomControllerFactory>().LifeStyle.Singleton);
            Container.Register(Component.For<ILogger>().ImplementedBy<Log4NetLogger>().LifeStyle.Singleton);
            Container.Register(Component.For<IFormatterSelector>().ImplementedBy<FormatSelector>().LifeStyle.Singleton);
            Container.Register(Component.For<IHttpController>().ImplementedBy<BooksController>().Named("Books").LifeStyle.Transient);

            var config = GlobalConfiguration.Configuration;
            config.ServiceResolver.SetResolver(t => Container.Resolve(t), t => Container.ResolveAll(t).Cast<object>());

            AreaRegistration.RegisterAllAreas();

            RegisterGlobalFilters(GlobalFilters.Filters);
            RegisterRoutes(RouteTable.Routes);

            BundleTable.Bundles.RegisterTemplateBundles();
        }

    public class CustomControllerFactory : IHttpControllerFactory
    {
        private readonly IKernel kernel;
        public CustomControllerFactory(IKernel kernel)
        {
            this.kernel = kernel;
        }

        public IHttpController CreateController(HttpControllerContext controllerContext, string controllerName)
        {
            var res= kernel.Resolve<IHttpController>(controllerName);
            return res;
        }

        public void ReleaseController(IHttpController controller)
        {
            kernel.ReleaseComponent(controller);
        }
    }

but I'm getting a 'Object reference not set to an instance of an object.' error all the time... eventhough I can see that the container i resolving the type...

Also it seems like I have to register a ILogger and IFormatSelector into the container... but do I have to implement these myself or do can I just some default ones?

TIA

Søren

Re: How do I use Windsor as IoC?

Ahh.... seems like I have to register a lot of different stuff to make it work:

public static void Start()
        {
            var configuration = GlobalConfiguration.Configuration;
            Container.Register(Component.For<IHttpControllerFactory>().ImplementedBy<CustomControllerFactory>().LifeStyle.Singleton);
            Container.Register(Component.For<ILogger>().ImplementedBy<Log4NetLogger>().LifeStyle.Singleton);
            Container.Register(Component.For<IFormatterSelector>().ImplementedBy<FormatterSelector>().LifeStyle.Singleton);
            Container.Register(Component.For<IHttpControllerActivator>().ImplementedBy<DefaultHttpControllerActivator>().LifeStyle.Transient);
            Container.Register(Component.For<IHttpActionSelector>().ImplementedBy<ApiControllerActionSelector>().LifeStyle.Transient);
            Container.Register(Component.For<IActionValueBinder>().ImplementedBy<DefaultActionValueBinder>().LifeStyle.Transient);
            Container.Register(Component.For<IHttpActionInvoker>().ImplementedBy<ApiControllerActionInvoker>().LifeStyle.Transient);
            Container.Register(Component.For<System.Web.Http.Metadata.ModelMetadataProvider>().ImplementedBy<System.Web.Http.Metadata.Providers.CachedDataAnnotationsModelMetadataProvider>().LifeStyle.Transient);
            Container.Register(Component.For<HttpConfiguration>().Instance(configuration));
           
            Container.Register(Component.For<IHttpController>().ImplementedBy<BooksService>().Named("Books").LifeStyle.Transient);

            configuration.ServiceResolver.SetResolver(t => Container.Resolve(t), t => Container.ResolveAll(t).Cast<object>());

            AreaRegistration.RegisterAllAreas();

            RegisterGlobalFilters(GlobalFilters.Filters);
            RegisterRoutes(RouteTable.Routes);

            BundleTable.Bundles.RegisterTemplateBundles();
        }

and follow what 'james-world' is doing here: http://forums.asp.net/t/1770736.aspx/1?Implementing+IHttpControllerFactory+CreateController

    public class CustomControllerFactory : IHttpControllerFactory
    {
        private readonly HttpConfiguration configuration;
        private readonly IKernel kernel;

        public CustomControllerFactory(HttpConfiguration configuration, IKernel kernel)
        {
            this.configuration = configuration;
            this.kernel = kernel;
            }

        public IHttpController CreateController(HttpControllerContext controllerContext, string controllerName)
        {
            var controller = kernel.Resolve<IHttpController>(controllerName);
            controllerContext.Controller = controller;
            controllerContext.ControllerDescriptor =new HttpControllerDescriptor(configuration, controllerName, controller.GetType());
            return controllerContext.Controller;
        }

        public void ReleaseController(IHttpController controller)
        {
            kernel.ReleaseComponent(controller);
        }
    }

seems a little complicated though....

Re: How do I use Windsor as IoC?

You should return null from your resolving logic if you cannot resolve the type in question - i.e. if the type is not resolvable by the container you configured (with only the types you need) then return null. In this case the default resolver kicks in (and you do not need to care about the rest...).

Please see samples here: https://github.com/ChristianWeyer/Thinktecture.Web.Http

Re: How do I use Windsor as IoC?

Ok, so I should change my SetResolver to:

configuration.ServiceResolver.SetResolver(t =>
                                                          {
                                                              try
                                                              {
                                                                  return Container.Resolve(t);
                                                              }
                                                              catch (ComponentNotFoundException ex)
                                                              {
                                                                  return null;
                                                              }
                                                          },
                                                      t =>
                                                          {
                                                              try
                                                              {
                                                                  return Container.ResolveAll(t).Cast<object>();
                                                              }
                                                              catch (ComponentNotFoundException ex)
                                                              {
                                                                  return null;

                                                              }
                                                          });

... yes that seems to work

Thx,

Søren

Re: How do I use Windsor as IoC?

Since SetResolver sample does not provide an hook for "Release" seems to be a time-bomb with mature IoC container such Windsor... if you do not explicit call Release on root component such controller(most likely they have been created as Transient) you gonna experiencing a huge memory leaks

IHttpControllerFactory seems the only safe approach.

Re: How do I use Windsor as IoC?

Ok, so the best approach would be to use:

configuration.ServiceResolver.SetService(typeof (IHttpControllerFactory), new CustomControllerFactory(configuration, Container));

rather than changing the ServiceResolver for everything.

Søren

Re: How do I use Windsor as IoC?

even better without the try catch:

config.ServiceResolver.SetResolver(
   t => { container.Kernel.HasComponent(t) ? container.Resolve(t) : null },
   t => { container.Kernel.HasComponent(t) ? container.ResolveAll(t).Cast<object>() : new List<object>()});