Mike, yup that is basically it, anyplace your comparing the dates for the label at the top to shoe the close or open and to disable the submit button you will need to make sure everything is compare in same units. Are you plannign a quick fix and a new version
for this or will we need to compile the source and make the changes ourselves?
s2k, I will compile this change tonight and then repost a quick fix. You brought up some other points in your code that I want everyone to be clear on - I should ALWAYS be using UniversalTime for any decisions that are based on dates/times. The dates/times
in SQL Server are stored as UniversalTime (i.e. no offsets). The only situation where dates/times should ever be converted to localtime is when the date/time is going to be displayed to the user. I use the word "should" because I have obviously missed some
spots. I added UTC after almost all of the code was finished - sorry about that! I'll post back here when the fix is posted. I will simply post a new dll - nothing else. mike.
After getting home, making the fixes and then compiling them, I realized that I'm halfway through making the fix for the "late user" bug. So, my build was breaking. Luckily, bilybob has also been making some changes to the codebase and waiting patiently for
me to incorporate them into the official build. Since he's already got the changes in his code, he will post them into the forum for folks to download. Stay tuned for his post! mike.
In the interest of getting the best version of the pool out there for general use, I am happy to offer some of the changes I've made. I would hate to see multiple versions of this grow into a mess, but I think some of the changes I made make the pool that much
more useful to those who want to run it for the upcoming NFL season. I'm no DNN expert, and due to that, I have no idea how to release a nice packaged up module. Therefore, I figure I would release the files that I've changed. You would install the PickEm
module as normal, then replace certain files with mine. Here are some changes that I remember: - ability to send reminder emails to users who haven't yet made their weekly picks - 'Grid' screen, once the week is closed, shows all users and their picks. Pick
is outlined in red/green for wrong/right. An easy way to monitor the week's progress. - UTC bug fixed - Fixed up the NFL schedule so it imported right for me (times were wrong?) One bug I haven't fixed is the New User bug. Mike (or anyone) if this is relatively
simple, and you want to tell me what to do or send me a file, I will incorporate it. I will try and get a link to the required files up sometime today. Most importantly, I'd like to thank Mike for making this module. Hopefully when he has a little more time
he will be able to consolidate the code once again. Great job Mike!
bilybob - sounds great. Any chance you could laso provide the source code of your changes? I have made the UTC changes on my copy but your other changes sound great as well and I'd love to get them in place this week to test. If you need a host for the files
let me know and I would be happy to link a copy.
Here is a link to a modified Pickem DLL to corretc the UTC issues. http://www.schoonersolutions.com/files/aream.dnn.modules.pickem.dll Just place it in your DNN BIN folder to replace the current file. I have only done limited testing on this so please use at
your own risk. The changes that Bilybob has sent me requires some DB changes. I am currently looking into them and will post this update as well IF I get time to get it working.
The NFL XML Schedule file needs some work. There are a few games with incorrect times and week 17 has the wrong year for all the games and the week cutoff.
Another potential problem with UTC. When we have the time change this fall all of the UTC offsets will be different. Therefor the XML time offsets need to account for this. http://setiathome.ssl.berkeley.edu/utc.html UTC is nothing but a headache IMHO. We are
now having to deal with UTC, server time, game time, and user local time so becareful with your pool setup.
s2k
Contributor
2617 Points
527 Posts
Re: Pick'Em Sports Pool module released for free
Aug 30, 2004 07:07 PM|LINK
mm53bar
Participant
1570 Points
314 Posts
Re: Pick'Em Sports Pool module released for free
Aug 30, 2004 07:51 PM|LINK
mm53bar
Participant
1570 Points
314 Posts
Re: Pick'Em Sports Pool module released for free
Aug 31, 2004 01:51 AM|LINK
s2k
Contributor
2617 Points
527 Posts
Re: Pick'Em Sports Pool module released for free
Aug 31, 2004 10:16 AM|LINK
bilybob
Member
65 Points
13 Posts
Re: Pick'Em Sports Pool module released for free
Aug 31, 2004 12:27 PM|LINK
s2k
Contributor
2617 Points
527 Posts
Re: Pick'Em Sports Pool module released for free
Aug 31, 2004 12:37 PM|LINK
bilybob
Member
65 Points
13 Posts
Re: Pick'Em Sports Pool module released for free
Aug 31, 2004 12:54 PM|LINK
s2k
Contributor
2617 Points
527 Posts
Re: Pick'Em Sports Pool module released for free
Aug 31, 2004 02:13 PM|LINK
s2k
Contributor
2617 Points
527 Posts
Re: Pick'Em Sports Pool module released for free
Sep 02, 2004 12:36 AM|LINK
s2k
Contributor
2617 Points
527 Posts
Re: Pick'Em Sports Pool module released for free
Sep 04, 2004 08:58 PM|LINK