I am working in MVC 3, using DataAnnotations for clientside validation of a model that is contained inside a viewmodel (along with other items) bound to a partial view. I have a submit button on the partial view that does an ajax post containing a json
object with the formdata.
ie.
public class MyViewModel
{
public string SelectedInstallations {get;set;}
public MyModelClass Client {get;set;}
}
public class MyModelClass
{
[Required(ErrorMessage="Client Name is required.")]
[StringLength(50, ErrorMessage = "Client Name must be 50 characters or fewer")]
public string ClientName { get; set; }
[Required(ErrorMessage = "Abbreviation is required.")]
[StringLength(6, ErrorMessage = "Abbreviation must be 6 characters or fewer")]
public string Abbreviation { get; set; }
public bool IsActive { get; set; }
}
Inside the view:
$.post($(formToSubmit).attr("action"),
{ ClientName: $(formToSubmit).find("#CurrentClient_ClientName").val(),
Abbreviation: $(formToSubmit).find("#CurrentClient_Abbreviation").val(),
IsActive: $(formToSubmit).find("#CurrentClient_IsActive").is(':checked'),
SelectedInstallations: installations //this is populated via JS, details omitted
},
function (data) {
//Contents omitted
}, "json");
return false;
I have created a custom model binder by deriving from DefaultModelBinder, and it is binding the object properly.
Here's what is happening if I submit the form with bad data (in this case, no req'd fields populated):
By the time MyModelBinder gets called, the client side validation has already occurred (I can see in the HTML that the proper validation messages are showing up). Then the MyModelBinder runs through and populates the model with whatever it has. Then it calls the action method on the controller.
[AcceptVerbs(HttpVerbs.Post)]
public JsonResult JsonCreate(MyViewModel clientVM)
{
if (ModelState.IsValid) /// <--- this is showing true even when it should be false!
{
var saveResult = _clientRepository.SaveClient(clientVM.Client);
if (!saveResult.IsSuccess)
{
//handle errors omitted
return Json(new {IsSuccess = false});
}
//if we got here we succeeded
return
Json(
new
{
IsSuccess = true
});
}
return Json(new {IsSuccess = false});
}
The problem - in the action method, ModelState.IsValid is showing up as true even though the model has none of the required fields. So the controller then calls the repository to save the data, which of course fails with expected errors because it's missing
the fields.
While this might all be fine and dandy from the user perspective I want to be able to abort the attempt to save as soon as it reaches the controller -- so I need ModelState.IsValid to be set to false when the model fails validation. ETA: I found ModelState
on the bindingContext but it is set to IsValid=true when it enters the ModelBinder despite the client validation having triggered.
What can I do to ensure that the ModelState is accurate when it hits the action method on the controller in this scenario, so that the app doesn't waste time and resources trying to do the save (which in my application is a WCF service call by the repository)
when it is doomed to fail, without repeating the validation in the controller and/or the modelbinder?
Thanks in advance for your help and being patient with someone new to MVC :)
--
Anye Mercy
AnyeDotNet.blogspot.com
Please "Mark as Answer" the posts that help you - this lets others know the problem has been solved and helps others having the same problem know which solution works. Thanks!
I looked at the code in reflector and DefaultModelBinder 'SetProperty' method is the one which is responsible for validation and set the error message. I understand that Model Binding and Validation are two different steps and Default Model Binder is not
able to validate your model, there could be many reasons for this. Some of them outlined here.
I would suggest to use the DataAnnotationModelBinder or can override the OnPropertyValidating method of DefaultModelBinder to have your validation perfromed.
ModelState.IsValid is just a check if the error collection is empty. your binder must not be adding errors for missing required firelds. only your binder knows if the missing required were included in the postback.
Bruce - So is what you are saying that the ModelBinder *has* to be the one to add the errors, even though the clientside validation already kicked in? IE in a normal "DefaultModelBinder" scenario using JS ajax it is still actually going to the server even
if clientside validation failed, as opposed to aborting the call as soon as it saw that the validation failed?
It seems to me that client side validation only does something useful if it prevents contacting the server at all when there is a validation problem. I wouldn't have thought that I should *have* to add the errors inside the model binder if the client side
validation were doing its job properly. Otherwise, why bother doing it clientside at all, if it's going to call the server and revalidate there anyway?
(I had already read both of the links that the CPrakash82 posted, neither applied to my scenario directly. I will try switching from deriving from DataAttributeModelBinder instead of the DefaultModelBinder though to see if I can at least eliminate some redundancy)
Thanks!
--
Anye Mercy
AnyeDotNet.blogspot.com
Please "Mark as Answer" the posts that help you - this lets others know the problem has been solved and helps others having the same problem know which solution works. Thanks!
I would suggest to use the DataAnnotationModelBinder or can override the OnPropertyValidating method of DefaultModelBinder to have your validation perfromed.
After doing more reading the DataAnnotationsModelBinder is the default in MVC2+. The version you can find online was written for MVC 1 and is incompatible with MVC 3 - it required several changes to even compile and it still fails at runtime using obsolete
setters.
I *can* add model errors in my model binder manually but again, this defeats the whole purpose of having client-side validation.
--
Anye Mercy
AnyeDotNet.blogspot.com
Please "Mark as Answer" the posts that help you - this lets others know the problem has been solved and helps others having the same problem know which solution works. Thanks!
anyeone
Member
65 Points
27 Posts
ModelState not updated when deriving from DefaultModelBinder even though clientside validation fi...
May 23, 2012 03:27 PM|LINK
Hi all,
I am working in MVC 3, using DataAnnotations for clientside validation of a model that is contained inside a viewmodel (along with other items) bound to a partial view. I have a submit button on the partial view that does an ajax post containing a json object with the formdata.
ie.
public class MyViewModel { public string SelectedInstallations {get;set;} public MyModelClass Client {get;set;} } public class MyModelClass { [Required(ErrorMessage="Client Name is required.")] [StringLength(50, ErrorMessage = "Client Name must be 50 characters or fewer")] public string ClientName { get; set; } [Required(ErrorMessage = "Abbreviation is required.")] [StringLength(6, ErrorMessage = "Abbreviation must be 6 characters or fewer")] public string Abbreviation { get; set; } public bool IsActive { get; set; } } Inside the view: $.post($(formToSubmit).attr("action"), { ClientName: $(formToSubmit).find("#CurrentClient_ClientName").val(), Abbreviation: $(formToSubmit).find("#CurrentClient_Abbreviation").val(), IsActive: $(formToSubmit).find("#CurrentClient_IsActive").is(':checked'), SelectedInstallations: installations //this is populated via JS, details omitted }, function (data) { //Contents omitted }, "json"); return false;I have created a custom model binder by deriving from DefaultModelBinder, and it is binding the object properly.
Here's what is happening if I submit the form with bad data (in this case, no req'd fields populated):
By the time MyModelBinder gets called, the client side validation has already occurred (I can see in the HTML that the proper validation messages are showing up). Then the MyModelBinder runs through and populates the model with whatever it has. Then it calls the action method on the controller.
[AcceptVerbs(HttpVerbs.Post)] public JsonResult JsonCreate(MyViewModel clientVM) { if (ModelState.IsValid) /// <--- this is showing true even when it should be false! { var saveResult = _clientRepository.SaveClient(clientVM.Client); if (!saveResult.IsSuccess) { //handle errors omitted return Json(new {IsSuccess = false}); } //if we got here we succeeded return Json( new { IsSuccess = true }); } return Json(new {IsSuccess = false}); }The problem - in the action method, ModelState.IsValid is showing up as true even though the model has none of the required fields. So the controller then calls the repository to save the data, which of course fails with expected errors because it's missing the fields.
While this might all be fine and dandy from the user perspective I want to be able to abort the attempt to save as soon as it reaches the controller -- so I need ModelState.IsValid to be set to false when the model fails validation. ETA: I found ModelState on the bindingContext but it is set to IsValid=true when it enters the ModelBinder despite the client validation having triggered.
What can I do to ensure that the ModelState is accurate when it hits the action method on the controller in this scenario, so that the app doesn't waste time and resources trying to do the save (which in my application is a WCF service call by the repository) when it is doomed to fail, without repeating the validation in the controller and/or the modelbinder?
Thanks in advance for your help and being patient with someone new to MVC :)
Anye Mercy
AnyeDotNet.blogspot.com
Please "Mark as Answer" the posts that help you - this lets others know the problem has been solved and helps others having the same problem know which solution works. Thanks!
CPrakash82
All-Star
18720 Points
2899 Posts
Re: ModelState not updated when deriving from DefaultModelBinder even though clientside validatio...
May 24, 2012 01:17 PM|LINK
I looked at the code in reflector and DefaultModelBinder 'SetProperty' method is the one which is responsible for validation and set the error message. I understand that Model Binding and Validation are two different steps and Default Model Binder is not able to validate your model, there could be many reasons for this. Some of them outlined here.
http://bradwilson.typepad.com/blog/2010/01/input-validation-vs-model-validation-in-aspnet-mvc.html
http://odetocode.com/blogs/scott/archive/2009/04/27/6-tips-for-asp-net-mvc-model-binding.aspx
I would suggest to use the DataAnnotationModelBinder or can override the OnPropertyValidating method of DefaultModelBinder to have your validation perfromed.
I hope this will help.
Thanks,
bruce (sqlwo...
All-Star
37594 Points
5573 Posts
Re: ModelState not updated when deriving from DefaultModelBinder even though clientside validatio...
May 24, 2012 01:22 PM|LINK
ModelState.IsValid is just a check if the error collection is empty. your binder must not be adding errors for missing required firelds. only your binder knows if the missing required were included in the postback.
anyeone
Member
65 Points
27 Posts
Re: ModelState not updated when deriving from DefaultModelBinder even though clientside validatio...
May 24, 2012 02:06 PM|LINK
Bruce - So is what you are saying that the ModelBinder *has* to be the one to add the errors, even though the clientside validation already kicked in? IE in a normal "DefaultModelBinder" scenario using JS ajax it is still actually going to the server even if clientside validation failed, as opposed to aborting the call as soon as it saw that the validation failed?
It seems to me that client side validation only does something useful if it prevents contacting the server at all when there is a validation problem. I wouldn't have thought that I should *have* to add the errors inside the model binder if the client side validation were doing its job properly. Otherwise, why bother doing it clientside at all, if it's going to call the server and revalidate there anyway?
(I had already read both of the links that the CPrakash82 posted, neither applied to my scenario directly. I will try switching from deriving from DataAttributeModelBinder instead of the DefaultModelBinder though to see if I can at least eliminate some redundancy)
Thanks!
Anye Mercy
AnyeDotNet.blogspot.com
Please "Mark as Answer" the posts that help you - this lets others know the problem has been solved and helps others having the same problem know which solution works. Thanks!
anyeone
Member
65 Points
27 Posts
Re: ModelState not updated when deriving from DefaultModelBinder even though clientside validatio...
May 24, 2012 02:46 PM|LINK
After doing more reading the DataAnnotationsModelBinder is the default in MVC2+. The version you can find online was written for MVC 1 and is incompatible with MVC 3 - it required several changes to even compile and it still fails at runtime using obsolete setters.
I *can* add model errors in my model binder manually but again, this defeats the whole purpose of having client-side validation.
Anye Mercy
AnyeDotNet.blogspot.com
Please "Mark as Answer" the posts that help you - this lets others know the problem has been solved and helps others having the same problem know which solution works. Thanks!