DotNetNuke

Re: 3.2 solpart issue?

jhenning — Wed, 23 Nov 2005 16:51:23 GMT

I am sure it is possible, though I am not the guy to determine if we do it... you may want to suggest this with the skin's author. (Nina, I believe).

Re: 3.2 solpart issue?

oakley — Sun, 20 Nov 2005 23:03:23 GMT

Hey Jon,

In bridging between the existing method and the new suggested method, it would be useful to have a version of the default skins posted at DotNetNuke.com. Would this be possible?

Re: 3.2 solpart issue?

vasilis — Thu, 10 Nov 2005 01:52:36 GMT

Hey Jon, really thanks for that!

You did a great job organizing all this stuff!

The Navigation Elements document is very detailed and helpful!

Sure, you can count on me if you need a tester in the future!

Thanks again!

Re: 3.2 solpart issue?

jhenning — Thu, 10 Nov 2005 01:11:30 GMT

Of course there is a much easier way around this issue if you can edit the skin. As the document states I am recommending everyone move towards the more organized way of setting these styles... so in your case if you used the CSSNodeSelectedRoot property in place of the RootMenuItemSelectedCssClass property it should work as well.

Re: 3.2 solpart issue?

jhenning — Thu, 10 Nov 2005 00:10:30 GMT

You are correct, though it is not a solpart issue, rather a bug in how I am mapping the menu skin object to the underlying navobject object. If you are reading the navigation controls document you will notice an excel chart mapping the old properties to the new organized properties. I have the RootMenuItemActiveCssClass and mapped to the CSSNodeSelectedRoot property and the RootMenuItemSelectedCssClass mapped to the CSSNodeHoverRoot when it should be the other way around. Similary, the same properties dealing with the Sub items are swapped as well.

So if you don't mind recompiling the core and need this fixed you could open up the SolpartMenu.ascx.vb file in admin\skins and replace the appropriate properties with this code.

<code>
  Public Property RootMenuItemActiveCssClass() As String
   Get
    Return Me.CSSNodeHoverRoot
   End Get
   Set(ByVal Value As String)
    Me.CSSNodeHoverRoot = Value
   End Set
  End Property

  Public Property SubMenuItemActiveCssClass() As String
   Get
    Return Me.CSSNodeHoverSub
   End Get
   Set(ByVal Value As String)
    Me.CSSNodeHoverSub = Value
   End Set
  End Property

  Public Property RootMenuItemSelectedCssClass() As String
   Get
    Return Me.CSSNodeSelectedRoot
   End Get
   Set(ByVal Value As String)
    Me.CSSNodeSelectedRoot = Value
   End Set
  End Property

  Public Property SubMenuItemSelectedCssClass() As String
   Get
    Return Me.CSSNodeSelectedSub
   End Get
   Set(ByVal Value As String)
    Me.CSSNodeSelectedSub = Value
   End Set
  End Property
</code>

Thank you for pointing this out, for it is important. Mapping all these properties was quite a chore and I was unsure I got them all correct. This is why I recruited some skinners out there to try and regression test these changes against their existing skins. Unfortunately this is one they missed. If I ever undertake something like this again, I know who I will recruit as one of my testers :)

3.2 solpart issue?

vasilis — Wed, 09 Nov 2005 21:34:15 GMT

Before I describe the issue I have to say many thanks for all the effort to release this new version.

I know that Jon Henning has done a great job for many of the new features.

The issue I have might not be that important, but it does cause a backwards compatibility problem with many existing skins.

As you can see at http://test.thinkofdesign.com/ (clean 3.2 installation) the solpart menu on the left doesn't work properly when it comes to the current tab style. (try to mouse over the menu items and you 'll get it)

This is the code in my skin.ascx

<dnn:SOLPARTMENU runat="server" id="dnnSOLPARTMENU" display="vertical" downarrow="breadcrumb.gif" userootbreadcrumbarrow="false" usesubmenubreadcrumbarrow="false" rootmenuitemcssclass="rootmenuitem" rootmenuitemselectedcssclass="rootmenuitemselected" rootmenuitembreadcrumbcssclass="rootmenuitembreadcrumb" submenucssclass="submenu" submenuitemselectedcssclass="submenuitemselected" submenuitembreadcrumbcssclass="submenuitembreadcrumb" />

When you are at the home page this is the CSS class for the home menu item in the rendered source:

class="dnn_dnnsolpartmenu_ctldnnsolpartmenu_spmbar dnn_dnnsolpartmenu_ctldnnsolpartmenu_spmitm MainMenu_MenuBar MainMenu_MenuItem"

so my custom rootmenuitembreadcrumb CSS class isn't there.

If you browse a second or third level tab you 'll see that the parent level tab is highlighted as it has to be but it's not the same for the current tab.

I can find my custom CSS class in the code for the parent root tab:

class="dnn_dnnsolpartmenu_ctldnnsolpartmenu_spmbar dnn_dnnsolpartmenu_ctldnnsolpartmenu_spmitm MainMenu_MenuBar MainMenu_MenuItem rootmenuitembreadcrumb"

So I think that the problem is with the CSS class that has to be applied to the current tab... though that's an hypothesis.

Hope I described it well...

(...still reading the new Navigation Controls document)