Web Forms

Re: ImageButton on Command - not firing

BenHur — Wed, 22 Jul 2009 18:47:07 GMT

Thanks a lot for your help.

Seems to work like a charm, now.

The conclusion is to use ViewState for this kind of operation.

Thanks again.

Re: ImageButton on Command - not firing

Gary yang - MSFT — Mon, 06 Jul 2009 02:26:48 GMT

Hi BenHur,

Based on your description, it seems that you want to re-load and bing data to the Repeater with different condition. Actually, please try to fire the outside event of UpdatePanel with AsyncPostBackTrigger/PostBackTrigger. And please refer to the following code:

1. I put a LinkButton outside UpdatePanel and regist it in UpdatePanel with AsyncPostBackTrigger(if you want to post back you can regist it with PostBackTrigger).

2. Add related event on behind.

//HTML

<html xmlns="http://www.w3.org/1999/xhtml">
<head id="Head1" runat="server">
    <title>Untitled Page</title>
</head>
<body>
    <form id="form1" runat="server">
    <div>
       <AjaxToolkit:ToolkitScriptManager ID="TSM" runat="server">
       </AjaxToolkit:ToolkitScriptManager>
        <asp:UpdatePanel ID="UpdatePanel1" runat="server">
        <ContentTemplate>
        
        
       <asp:Repeater ID="rep_First" runat="server" DataSourceID="SqlDataSource1" 
            onitemcommand="rep_First_ItemCommand">
         <ItemTemplate>
         <table border="1" width="150px">
           <tr><td>
                <asp:Label ID="Label1" runat="server" Text='<%#Eval("CategoryName") %>'></asp:Label>      
           </td>
           <td>
               <asp:ImageButton ID="ImageButton1" runat="server" ImageUrl="~/Image/x.jpg"
                CommandArgument='<%#Eval("CategoryID") %>' CommandName="Click" />
           </td>
           </tr>
         </table>
         </ItemTemplate>
       </asp:Repeater>
       </ContentTemplate>
       <Triggers>
         <asp:AsyncPostBackTrigger ControlID="LinkButton1"/>
       </Triggers>
        </asp:UpdatePanel>
        <asp:SqlDataSource ID="SqlDataSource1" runat="server" 
            ConnectionString="<%$ ConnectionStrings:connstr %>" ></asp:SqlDataSource>
        <asp:LinkButton ID="LinkButton1" runat="server" onclick="LinkButton1_Click">OutSiteUdatePanel</asp:LinkButton>  
    </div>
    </form>
</body>
</html>

//code

using System;
using System.Configuration;
using System.Data;
using System.Linq;
using System.Web;
using System.Web.Security;
using System.Web.UI;
using System.Web.UI.HtmlControls;
using System.Web.UI.WebControls;
using System.Web.UI.WebControls.WebParts;
using System.Xml.Linq;

public partial class Test4 : System.Web.UI.Page
{
    protected void Page_Load(object sender, EventArgs e)
    {
        if (!IsPostBack)
            DataBinds();
    }
    void DataBinds()
    {
        string strSelect = string.Empty;
        int strID = ViewState["ID"] == null ? -1 : int.Parse(ViewState["ID"].ToString());
        if (strID > -1)
        {
            strSelect = "SELECT [CategoryName], [CategoryID] FROM [Categories] where [CategoryID]=" + strID;
        }
        else
            strSelect = "SELECT [CategoryName], [CategoryID] FROM [Categories] ";
        SqlDataSource1.SelectCommandType = SqlDataSourceCommandType.Text;
        SqlDataSource1.SelectCommand = strSelect;
    }
    protected void rep_First_ItemCommand(object source, RepeaterCommandEventArgs e)
    {
        if (e.CommandName == "Click")
        {
            ViewState["ID"] = e.CommandArgument;
            DataBinds();
        }
    }
    protected void LinkButton1_Click(object sender, EventArgs e)
    {
        ViewState["ID"] = null;
        DataBinds();
    }
}

Re: ImageButton on Command - not firing

BenHur — Sun, 05 Jul 2009 13:16:55 GMT

Hi Gary,

Firstly, thanks for your patience with this problem.

You code is succesfully working but my scenario is a little bit more complex.

I will not put my entire page here because i have over 1000 lines of code but i do put only the thing that shows you that i really need calling DataBind on my repeater:

So, on your example i put another Link Button outside of the updatePanel.

When clicking this link btn a full postback is being done.

And i put this in page load:

 if (!IsPostBack)
            DataBinds();
        else
        {
            SqlDataSource1.SelectCommandType = SqlDataSourceCommandType.Text;
            SqlDataSource1.SelectCommand = "SELECT [Nume], [Categorii_id] FROM [Categorii] ";
            //DataBind();
        }

If you press the ImgBtn from the updatepanel, in our scenario it shows only one category. And after that,

if i press this lnk btn it takes the new sql command (proved with debug) but without the DataBind() applied to the repeater it shows only that one category for previous rendering.

Can you test and prove if i am right?

Another chance would be to delete the previous state of the repeater and force it to do a refresh

every time when the page is postbacked, but i do not know how....

Thanks a lot

Re: ImageButton on Command - not firing

Gary yang - MSFT — Sat, 04 Jul 2009 15:05:21 GMT

Hi BenHur,

Here, I create a whole demo that you can refer to, if you have any problem, please post your whole code for us checking.

<html xmlns="http://www.w3.org/1999/xhtml">
<head runat="server">
    <title>Untitled Page</title>
</head>
<body>
    <form id="form1" runat="server">
    <div>
       <AjaxToolkit:ToolkitScriptManager ID="TSM" runat="server">
       </AjaxToolkit:ToolkitScriptManager>
        <asp:UpdatePanel ID="UpdatePanel1" runat="server">
        <ContentTemplate>
        
        
       <asp:Repeater ID="rep_First" runat="server" DataSourceID="SqlDataSource1" 
            onitemcommand="rep_First_ItemCommand">
         <ItemTemplate>
         <table border="1" width="150px">
           <tr><td>
                <asp:Label ID="Label1" runat="server" Text='<%#Eval("CategoryName") %>'></asp:Label>      
           </td>
           <td>
               <asp:ImageButton ID="ImageButton1" runat="server" ImageUrl="~/Image/x.jpg"
                CommandArgument='<%#Eval("CategoryID") %>' CommandName="Click" />
           </td>
           </tr>
         </table>
         </ItemTemplate>
       </asp:Repeater>
       </ContentTemplate>
        </asp:UpdatePanel>
        <asp:SqlDataSource ID="SqlDataSource1" runat="server" 
            ConnectionString="<%$ ConnectionStrings:FirstString %>" ></asp:SqlDataSource>
            
    </div>
    </form>
</body>
</html>

Code:

using System;
using System.Configuration;
using System.Data;
using System.Linq;
using System.Web;
using System.Web.Security;
using System.Web.UI;
using System.Web.UI.HtmlControls;
using System.Web.UI.WebControls;
using System.Web.UI.WebControls.WebParts;
using System.Xml.Linq;

public partial class _Default : System.Web.UI.Page 
{
    protected void Page_Load(object sender, EventArgs e)
    {
        if (!IsPostBack)
            DataBinds();
    }
    void DataBinds()
    {
        string strSelect = string.Empty;
        int strID = ViewState["ID"] == null ? -1 : int.Parse(ViewState["ID"].ToString());
        if (strID > -1)
        {
            strSelect = "SELECT [CategoryName], [CategoryID] FROM [Categories] where [CategoryID]=" + strID;
        }
        else
            strSelect = "SELECT [CategoryName], [CategoryID] FROM [Categories] ";
        SqlDataSource1.SelectCommandType = SqlDataSourceCommandType.Text;
        SqlDataSource1.SelectCommand = strSelect;
    }
    protected void rep_First_ItemCommand(object source, RepeaterCommandEventArgs e)
    {
        if (e.CommandName == "Click")
        {
            ViewState["ID"] = e.CommandArgument;
            DataBinds();
        }
    }
}

Re: ImageButton on Command - not firing

BenHur — Sat, 04 Jul 2009 10:18:33 GMT

Not solved yet....

Any suggestions?

Re: ImageButton on Command - not firing

BenHur — Fri, 03 Jul 2009 17:31:36 GMT

Hi Gary,

I took your example, put it to my page and was not running...

I made a NEW page, only with your example and it was running !!!!

After another hour of struggling my head with the code...i discovered the point.

Why my function (your or that old mine) was not firing????

Because i manually put a SELECT command to my datasource and after that i bind it to the repeater.

And if i call repeaterDetalii.DataBind() (this my repeater which contains the ImageButton...and this repeater is a child of an updatePanel like said before), the method for the ImageButton Click is no longer fired.

If i comment //repeaterDetalii.DataBind() it works like a charm!!

Do you know why this things happen? I mention that i need to call the refresh of my repeater for some operation

when changing the select!

Please let me know if you have any solution.

 public void getCarti()
    {
        sqlDataSourceCarti.SelectCommand = select;
        sqlDataSourceCarti.DataBind();
        //repeaterDetalii.DataBind();
        repeaterImagini.DataBind();
        //aici punem curentpage ca fiind lastPage
        Session["lastPage"] = currentPage;
        UpdatePanelSortTop.Update();
    }

Gary you can just try to put Repeater1.DataBind() in your Page_Load method, and you'll see that your example is no longer working........

Re: ImageButton on Command - not firing

Gary yang - MSFT — Thu, 02 Jul 2009 02:36:05 GMT

BenHur:

So i have an UpdatePanel set to Conditional.

Inside it, i have a Repeater which contains that Image Button

Based on your description, it seems that you want to fire the Click event of ImageButton which host in Repeater. If this is the case, I suggest you solve it by using Repeater1_ItemCommand event instead of ImageButton_Click. Please refer to the following code:

    <form id="form1" runat="server">
    <asp:ScriptManager ID="ScriptManager1" runat="server">
    </asp:ScriptManager>
    <asp:UpdatePanel ID="UpdatePanel1" runat="server">
     <ContentTemplate>
         <asp:Repeater ID="Repeater1" runat="server" DataSourceID="SqlDataSource1" 
             onitemcommand="Repeater1_ItemCommand" >
         <ItemTemplate>
          <table>
            <tr><td>
               <asp:ImageButton ID="ImageButton1" runat="server"    
                        ImageUrl="~/Images/aspdotnet.png"    
                        CommandName="Click"    
                        CommandArgument='<%#Eval("CategoryID") %>' />  
                         <asp:Label ID="Label1" runat="server" Text="Label"></asp:Label>
            </td></tr>
          </table>   
         </ItemTemplate>
         </asp:Repeater>
     </ContentTemplate>
    </asp:UpdatePanel>
    <asp:SqlDataSource ID="SqlDataSource1" runat="server" 
        ConnectionString="<%$ ConnectionStrings:connstr %>" 
        SelectCommand="SELECT [CategoryID], [CategoryName] FROM [Categories]"></asp:SqlDataSource>
    </form>

Code:

    protected void Repeater1_ItemCommand(object source, RepeaterCommandEventArgs e)
    {
        if (e.CommandName == "Click")
        {
            Label obj = e.Item.FindControl("Label1") as Label;
            obj.Text = e.CommandArgument as string;
        }
    }

Re: ImageButton on Command - not firing

BenHur — Wed, 01 Jul 2009 19:25:39 GMT

It's not putted in !isPostBack. It is running every time the page loads.

Re: ImageButton on Command - not firing

mudassarkhan — Wed, 01 Jul 2009 19:22:11 GMT

BenHur:

view plain copy to clipboard print ?

Repeater repeaterDetalii = (Repeater)Tab1.FindControl("repeaterDetalii");



       foreach (RepeaterItem rptItem in repeaterDetalii.Items)

       {

           ImageButton imgBtnWishList = (ImageButton)rptItem.FindControl("imgBtnWishList");

           AsyncPostBackTrigger triggerWishList = new AsyncPostBackTrigger();

           //triggerWishList.EventName = "Click";

           triggerWishList.ControlID = imgBtnWishList.UniqueID.ToString();

           UpdatePanelSortTop.Triggers.Add(triggerWishList);

           _scriptMan.RegisterAsyncPostBackControl(imgBtnWishList);

       }

If this part is present in

!isPostBack condition remove from it so that it is executed on each request

Re: ImageButton on Command - not firing

BenHur — Wed, 01 Jul 2009 19:15:59 GMT

Sorry, but i do not understand what you mean.

So i have an UpdatePanel set to Conditional.

Inside it, i have a Repeater which contains that Image Button

I put:

<asp:ImageButton ID="imgBtnWishList" runat="server"

OnClick="addProductToWishList"

ImageUrl="../Site/images/featured-wishlist.jpg"

<asp:ImageButton ID="imgBtnWishList" runat="server" 
                        OnClick="addProductToWishList" 
                        ImageUrl="../Site/images/featured-wishlist.jpg" 
                        />

When the page is loading i register this ImageButton for the UpdatePanel as trigger:

 Repeater repeaterDetalii = (Repeater)Tab1.FindControl("repeaterDetalii");

        foreach (RepeaterItem rptItem in repeaterDetalii.Items)
        {
            ImageButton imgBtnWishList = (ImageButton)rptItem.FindControl("imgBtnWishList");
            AsyncPostBackTrigger triggerWishList = new AsyncPostBackTrigger();
            //triggerWishList.EventName = "Click";
            triggerWishList.ControlID = imgBtnWishList.UniqueID.ToString();
            UpdatePanelSortTop.Triggers.Add(triggerWishList);
            _scriptMan.RegisterAsyncPostBackControl(imgBtnWishList);
        }

And when the image button is clicked is should fire this method:

 public void addProductToWishList(object sender, EventArgs e)
    {
        ImageButton imgButton = (ImageButton)(sender);
        RepeaterItem rptParentItem = (RepeaterItem)imgButton.Parent;


        ImageButton imgBtnWishList = (ImageButton)sender;
        RepeaterItem repetear = (RepeaterItem)imgBtnWishList.Parent;

        if (MySession.Current.userId != 0)
        {
            int userId = MySession.Current.userId;
            wishQ.insertInWishList(userId, utils.getCategoryAliasById(category), getProductId(rptParentItem.ItemIndex));
        }
        else
        //
        {
            ModalPopupExtender loginPopUp = (ModalPopupExtender)Page.FindControl("loginPopUp");
            loginPopUp.Show();
        }

    }

That's all. If i put the ImageButton outside the UpdatePanel and comment the lines that triggers it,

it causes a postback and the method is fired.

But within the UpdatePanel, as i showed above the method is not FIRED :((

Anyone knows WHY???

Re: ImageButton on Command - not firing

mudassarkhan — Wed, 01 Jul 2009 18:59:09 GMT

It will not fire the event unless the eent is binded to the control before the click event handler is called

meaning every time you needto bind the event when the button is clicked and then only the event wil get called

Re: ImageButton on Command - not firing

BenHur — Wed, 01 Jul 2009 17:59:25 GMT

Yes, u are right.

Now the image button fires the method when clicked and do a postback too.

BUT if i put it inside the UpdatePanel and register the control like i showed above,

it no longer fires...

Do u know why?

Re: ImageButton on Command - not firing

mudassarkhan — Wed, 01 Jul 2009 17:39:22 GMT

You can get command argument on onclick event too

refer my article

http://www.aspsnippets.com/post/2009/06/27/ASPNet-GridView-Get-Row-Index-on-RowCommand-and-Click-events.aspx

Re: ImageButton on Command - not firing

BenHur — Wed, 01 Jul 2009 17:17:23 GMT

Hi mudassarkhan

I cannot use OnClick event because i need to send this CommandArgument="<%# Container.ItemIndex%>"

because i need it in the method.

Re: ImageButton on Command - not firing

BenHur — Wed, 01 Jul 2009 17:15:35 GMT

My ImageButton is inside a repeater which is inside an UpdatePanel.

I have registered as postback trigger like i;ve made for other buttons that worked.

Repeater repeaterDetalii = (Repeater)Tab1.FindControl("repeaterDetalii");

        foreach (RepeaterItem rptItem in repeaterDetalii.Items)
        {
            ImageButton imgBtnWishList = (ImageButton)rptItem.FindControl("imgBtnWishList");
            AsyncPostBackTrigger triggerWishList = new AsyncPostBackTrigger();
            //triggerWishList.EventName = "Click";
            triggerWishList.ControlID = imgBtnWishList.UniqueID.ToString();
            UpdatePanelSortTop.Triggers.Add(triggerWishList);
            _scriptMan.RegisterAsyncPostBackControl(imgBtnWishList);
        }

But the problem is the same.

My method (although i put it protected) still does not work.

I put breakpoints before started this thread but the method is not firing...

Any other advice?

Repeater repeaterDetalii = (Repeater)Tab1.FindControl("repeaterDetalii");

foreach (RepeaterItem rptItem in repeaterDetalii.Items)

{

ImageButton imgBtnWishList = (ImageButton)rptItem.FindControl("imgBtnWishList");

AsyncPostBackTrigger triggerWishList = new AsyncPostBackTrigger();

//triggerWishList.EventName = "Click";

triggerWishList.ControlID = imgBtnWishList.UniqueID.ToString();

UpdatePanelSortTop.Triggers.Add(triggerWishList);

_scriptMan.RegisterAsyncPostBackControl(imgBtnWishList);

}