Web Forms

Re: Button Click Fires Twice

worldspawn[] — Thu, 06 Nov 2008 23:10:34 GMT

Hey was I right?

Re: Button Click Fires Twice

worldspawn[] — Wed, 05 Nov 2008 07:25:02 GMT

Ok did a quick google.

The solution (maybe) is to remove the "Handles btnChgPwd.Click" bit from your handler definition. I think having that plus the OnClick bit in your aspx code essentially binds the method twice to the event, thus executes it twice. That's VB for ya!

My info came from:

http://bytes.com/forum/thread643743.html

Re: Button Click Fires Twice

geosync — Wed, 05 Nov 2008 06:16:27 GMT

For now, my workaround uses ViewState to restrict event processing to one pass:

If tbNewPwd.Text <> "" Then usr.ChangePassword(tbOldPwd.Text, tbNewPwd.Text)

If cbSendEmail.Checked And ViewState("MailSent") Is Nothing Then
  Dim mm As New MailMessage
  mm = New MailMessage
  mm.From = New MailAddress("name@domain.com")
  mm.To.Add(New MailAddress(usr.Email))
  mm.Subject = "Subject Goes Here"
  mm.Body = "Message text goes here."

  Dim sc As New SmtpClient()
  sc.Send(mm)

  ViewState("MailSent") = "TRUE"
End If

Re: Button Click Fires Twice

worldspawn[] — Wed, 05 Nov 2008 03:57:32 GMT

Ok... no suggestions sorry Does it still happen if your remove the confirm script?

Re: Button Click Fires Twice

geosync — Wed, 05 Nov 2008 02:22:05 GMT

Ah, code...I have reduced these files almost as far as they can go. Let me know what you think:

<%@ Page Language="VB" AutoEventWireup="false" CodeFile="UserMgmt.aspx.vb" Inherits="UserMgmt" %>

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">

<html xmlns="http://www.w3.org/1999/xhtml" >
<head runat="server">
    <title>Untitled Page</title>
</head>
<body>
    <form id="form1" runat="server">
    <div>
    <asp:Label ID="lblMain" runat="server"></asp:Label><br />
    <asp:Label ID="lblSub" runat="server" Text="Change Password"></asp:Label><br />
    <asp:Label ID="Label1" runat="server" AssociatedControlID="tbOldPwd" Text="Old:"></asp:Label>
    <asp:TextBox ID="tbOldPwd" runat="server"></asp:TextBox><br />
    <asp:Label ID="Label24" runat="server" AssociatedControlID="tbNewPwd" Text="New:"></asp:Label>
    <asp:TextBox ID="tbNewPwd" runat="server"></asp:TextBox><br />
    <asp:Label ID="Label25" runat="server" AssociatedControlID="tbConfirm" Text="Confirm:"></asp:Label>
    <asp:TextBox ID="tbConfirm" runat="server"></asp:TextBox><br />
    <asp:Button ID="btnChgPwd" runat="server" OnClick="btnChgPwd_Click" 
      OnClientClick="return confirm('Change password?')" Text="Change Password" /><br />
    <asp:CheckBox ID="cbSendEmail" runat="server" Checked="True" Text="Email User" />   
    </div>
    </form>
</body>
</html>

1    Partial Public Class UserMgmt
2      Inherits System.Web.UI.Page
3    
4      Private usr As MembershipUser
5    
6      Protected Sub Page_Load(ByVal sender As Object, ByVal e As EventArgs) Handles Me.Load
7    
8        If Not Page.IsPostBack Then
9          ' Pickup UserName from Session.
10         If Session("UserName") IsNot Nothing Then
11           ' Get membership object
12           usr = Membership.GetUser(Session("UserName").ToString)
13           ' Store membership object.
14           Session("USER") = usr
15           lblMain.Text = "Managing Details for " + usr.UserName
16         End If
17       Else
18         ' On postbacks, retrieve membership object from session.
19         usr = CType(Session("USER"), MembershipUser)
20       End If
21   
22     End Sub
23   
24     Protected Sub btnChgPwd_Click(ByVal sender As Object, ByVal e As EventArgs) Handles btnChgPwd.Click
25   
26       Try
27         If tbNewPwd.Text <> "" Then usr.ChangePassword(tbOldPwd.Text, tbNewPwd.Text)
28   
29         If cbSendEmail.Checked Then
30           Dim mm As New MailMessage
31           mm = New MailMessage
32           mm.From = New MailAddress("name@domain.com")
33           mm.To.Add(New MailAddress(usr.Email))
34           mm.Subject = "Subject Goes Here"
35           mm.Body = "Message text goes here."
36   
37           Dim sc As New SmtpClient()
38           sc.Send(mm)
39         End If
40       Catch eX As Exception
41   
42       Finally
43   
44       End Try
45   
46     End Sub
47   End Class
48   
49

Re: Button Click Fires Twice

worldspawn[] — Wed, 05 Nov 2008 00:09:55 GMT

Could be the position of mars in relation to uranus... no wait thats not right, post your code!!

Button Click Fires Twice

geosync — Tue, 04 Nov 2008 23:13:52 GMT

I've seen events fire twice if called from Page_Load; these issues are PostBack related.

But I don't understand my current situation:

My admin page called User Mgmt page has a Change Password button.

Click Change Password, and password is changed. Also, email is sent.

However, the code runs twice, and two emails are sent.

Why?