ASP.NET MVC

Re: Parameters were reordered in BeginForm()

Simon.Sanderson — Thu, 30 Oct 2008 05:42:04 GMT

I have just spent a significant amount of time trying to trace why, after installing the MVC Beta, my forms were being rendered thus:

<form action="" method="post">
:
:
</form>

where the action attribute is empty. The reason, rather tersely, is due to the low save observation made by canton where the controller and action parameters have been re-ordered in the BeginForm() method. I am suprised that more e-noise has not been made about this change.

Perhaps there is a case for a more strongly typed classes for Action and Controller names to help prevent similar annoyances like this from occuring in future? I know I shall be looking to implement such framework functionality asap .....

Re: Parameters were reordered in BeginForm()

Eilon — Fri, 17 Oct 2008 16:57:42 GMT

Hi there,

Sorry about forgetting this in the release notes. We did quite a few renames and reordered some parameters and must have missed that change. I think we missed it because in the "diff" that we did this change doesn't show up because renamed the method as well. The diff tool just thought we deleted the old Form() methods and added the brand new BeginForm() methods, so the parameter reordering didn't show up.

The number of changes like this should be much smaller now that the Beta is released, so I hope we don't run into this issue again. I'm glad that you at least found the issue in your app and fixed it!

Thanks,

Eilon

Parameters were reordered in BeginForm()

canton — Fri, 17 Oct 2008 09:24:03 GMT

In the process of migrating from MVC Preview 5 to Beta, I discovered an API change that bugs me a lot.

public static IDisposable Form(this HtmlHelper helper, string controllerName, string actionName)

was changed to

public static MvcForm BeginForm(this HtmlHelper htmlHelper, string actionName, string controllerName)

Notice that the position of controllerName and actionName got interchanged. This can't be detected by compiler, and must be fixed manually.

I understand this is more consistent to ActionLink(label, action, controller). And I also understand API in Preview versions is subject to huge changes. But many of us will be glad to see such changes documented in the Release Notes.