ASP.NET MVC

Re: MVCToolkit URL Bugs

mrfleck — Tue, 19 Feb 2008 15:45:22 GMT

One of these bugs is killing me right now. The one where it tacks on stuff from the URL even though you do not include that information in your Url.ActionLink or Url.Action. I have hardcoded links everywhere in the app I am working on now. I m hoping to get rid of that about Mix08 time. Any word if this is getting fixed in the next release?

Re: MVCToolkit URL Bugs

styx31 — Tue, 19 Feb 2008 11:01:20 GMT

tgmdbm:

Yes that is precisely it.
I've written a one liner for each of the individual bugs (Going by the order of the comment in the sample code)

1, RouteCollection.GetUrl: extra defaults in the Route brake URL resolution.
[check the way RouteCollection.GetUrl handles parsedRoute.OtherDefaultValues]

2, RouteCollection.GetUrl: if it's not a mapped argument, querystring it
3, i don't consider this a bug.
4, pass all argument name/value pairs to the call to Url.Action(object)
[this will be a no brainer when the MVC Framework accepts dictionaries as well as objects]

5a, RouteCollection.GetUrl: Don't include parameters that we didn't pass.

5b, same as 4. simply delegate to Url.Action, don't build the URL yourself.

Just to precise that ScottGu, in the Part 2 Tutorial, in "Constructing Outgoing URLs from the Routing System", explain in the "DRY" paragraph that :

The beauty of all of the above helper methods is that they enable us to avoid having to hard-code in URL paths within our Controller and View Logic. If at a later point we decide to change the search URL route mapping rule back from "/Search/[query]/[page]" to "/Search/Results/[query]/[page]" or "/Search/Results?query=[query]&page=[page]" we can easily do so by editing it in one place (our route registration code). We don't need to change any code within our views or controllers to pick up the new URL (this maintaining the "DRY principle").

In his sample, he clearly explain that the RoutingEngine should use querystring formatted format when a specific route is not available.

Next build ? Should be integrated in the base code ?

Re: MVCToolkit URL Bugs

Alexey.Kouzmitch — Tue, 12 Feb 2008 00:52:13 GMT

Wanted to weigh in:

[ControllerAction]
public void List(int page, int pageSize, string sortBy, string gameFilter, string mediaTypeFilter) {

also poses an issue.

Here's the routing rule:

RouteTable.Routes.Add(new Route
{
Url = "marketplace/[action]",
Defaults = new
{
controller = "Marketplace",
action = "List",
page = 0,
pageSize = 12,
sortBy = "Date",
gameFilter = (string)null,
mediaTypeFilter = (string)null
},
RouteHandler = typeof(MvcRouteHandler)
});

going to a url such as /marketplace/List?pageSize=5 doesn't override the default (so 12 is still passed to the controller).That behavior is evident from the Reflector view of Controller.InvokeActionMethod(MethodInfo methodInfo)

Re: MVCToolkit URL Bugs

Dokie — Wed, 16 Jan 2008 17:07:42 GMT

In my Create action I was using RenderView to go back to the same View post-validation when the information was invalid - I will now try Redirect instead. I will also look to change the Html.Form<T> to another alternative and see if that helps too - Thanks

Re: MVCToolkit URL Bugs

tgmdbm — Wed, 16 Jan 2008 16:50:14 GMT

This is a bug, not expected behaviour!

You shouldn't be rendering anything in the Create action, you should be redirecting to a Show or Edit action, that way this problem won't arise.

for the Html.ActionLink<T>() method, the only work around is to not use parameters on your actions or not to use that method.

Re: MVCToolkit URL Bugs

Dokie — Wed, 16 Jan 2008 15:33:55 GMT

I too am getting a repeated part to the URL when I am already on the View, e.g. I navigate to http://.../Registration/Create/Basic and on that View I have the following

Html.Form(action=>action.Create("Basic"), FormExtensions.FormMethod.post)

but my submit button has the URL http://.../Registration/Create/Basic/Basic and if I go there it becomes http://localhost:64701/Registration/Create/Basic/Basic/Basic. My routes I added in Global.asax are

            RouteTable.Routes.Add(new Route
            {
                Url = "Login",
                Defaults = new
                {
                    controller = "Security",
                    action = "Login"
                },
                RouteHandler = typeof (MvcRouteHandler)
            });

            RouteTable.Routes.Add(new Route
            {
                Url = "[controller]/[action]/[category]/[id]",
                Defaults = new
                {
                    action = "Index",
                    category = "Basic",
                    id = (string)null
                },
                RouteHandler = typeof(MvcRouteHandler)
            });

            RouteTable.Routes.Add(new Route
            {
                Url = "[controller]/[action]/[id]",
                Defaults = new
                {
                    action = "Index",
                    id = (string) null
                },
                RouteHandler = typeof (MvcRouteHandler)
            });

            RouteTable.Routes.Add(new Route
            {
                Url = "Default.aspx",
                Defaults = new
                {
                    controller = "Home",
                    action = "Index",
                    id = (string) null
                },
                RouteHandler = typeof (MvcRouteHandler)

Can anyone confirm that this is expected behaviour or a bug and any guidance as to how to workaround would be useful. Thanks in advance

Re: MVCToolkit URL Bugs

Shiznitt — Wed, 09 Jan 2008 23:46:16 GMT

Any news on these bugs? I am running into the last one,

using URL.Action:
<%= Url.Action(new { action = "Index", controller = "Goals", id = ViewData["NickName"].ToString() }) %>
I correctly get:
/Profiles/Testing123/Goals.mvc

using Html.ActionLink<>
<%= Html.ActionLink<GoalsController>(x => x.Index(ViewData["NickName"].ToString()), "test") %>
I incorrectly get:
/Profiles/Testing123/Goals.mvc/Testing123
If I am already on that page!

Re: MVCToolkit URL Bugs

tgmdbm — Tue, 01 Jan 2008 07:06:40 GMT

You're very welcome. I'm glad I could help.

And a happy new year to all!

Re: MVCToolkit URL Bugs

robconery — Tue, 01 Jan 2008 06:49:02 GMT

Good stuff - thanks for your patience. Queued this up for next week and I'll make sure it gets into the Toolkit.

Re: MVCToolkit URL Bugs

tgmdbm — Fri, 28 Dec 2007 13:37:23 GMT

Yes that is precisely it.

I've written a one liner for each of the individual bugs (Going by the order of the comment in the sample code)

1, RouteCollection.GetUrl: extra defaults in the Route brake URL resolution.
[check the way RouteCollection.GetUrl handles parsedRoute.OtherDefaultValues]

2, RouteCollection.GetUrl: if it's not a mapped argument, querystring it

3, i don't consider this a bug.

4, pass all argument name/value pairs to the call to Url.Action(object)
[this will be a no brainer when the MVC Framework accepts dictionaries as well as objects]

5a, RouteCollection.GetUrl: Don't include parameters that we didn't pass.

5b, same as 4. simply delegate to Url.Action, don't build the URL yourself.

Re: MVCToolkit URL Bugs

robconery — Fri, 28 Dec 2007 06:15:43 GMT

This is where I thought you were going with it, but then again I was confused between what you were calling "right" and what you were defining in your routes. If I can boil down what you're saying to "if it's not a mapped argument, querystring it" then yes - that does make sense.

I want to be sure I get this right - to elevate this I need a one sentence bug description that I can throw the core team. Sound fair?

Re: MVCToolkit URL Bugs

tgmdbm — Thu, 27 Dec 2007 15:13:23 GMT

Thanks for the positive feedback. Much appreciated.

Rob, did you get chance to test the sample code i posted?

If anybody else has tested it, I wouldn't mind a discussion on the individual bugs, if you have views on them.

Re: MVCToolkit URL Bugs

rjcox — Thu, 27 Dec 2007 09:01:08 GMT

abombss:
+1... That makes sense, extra params should be query string.

This then matches the request processing logic where query parameters are mapped to named parameters of the action method.

Re: MVCToolkit URL Bugs

abombss — Tue, 25 Dec 2007 21:07:08 GMT

+1... That makes sense, extra params should be query string.

Re: MVCToolkit URL Bugs

tgmdbm — Tue, 25 Dec 2007 20:42:32 GMT

/Products/List?category=apples&page=5

Simply put, if it's not matched in the Url of the Route then it's part of the querystring.

If i'm not mistaken, that is how the arguments of the Action are generated. This just makes complete sense to me.