CSS Friendly Control Adapters

Re: asp:DetailsView renders incorrectly with CSS friendly control adapter

hotfirewire — Fri, 04 May 2007 15:51:41 GMT

I've updated the code I was using. I had to add the line (If row.RowIndex < ControlAsDetailsView.Rows.Count - 1 Then) because I was getting an error every time I did an insert.

If row.RowIndex < ControlAsDetailsView.Rows.Count - 1 Then

If ((Not ControlAsDetailsView.AutoGenerateRows) AndAlso _

((row.RowState

And DataControlRowState.Insert) = DataControlRowState.Insert) AndAlso _

(

Not ControlAsDetailsView.Fields.Item(row.RowIndex).InsertVisible)) Then

Continue For

End If

Re: asp:DetailsView renders incorrectly with CSS friendly control adapter

hotfirewire — Fri, 04 May 2007 15:37:37 GMT

To fix the visible problem I added the following code to my DetailsViewAdapter.vb

writer.WriteLine()

writer.WriteBeginTag("li")

' Added in to check for visible=false & insertvisable=false rows

' Check for a row with valid fields

If row.RowIndex < ControlAsDetailsView.Rows.Count - 1 Then

' If visible is false set style to display:none

If ControlAsDetailsView.Fields.Item(row.RowIndex).Visible = False Then

writer.WriteAttribute(

"style", "display:none;")

End If

' If InsertVisible is false set style to display:none only on insert

If (ControlAsDetailsView.Fields.Item(row.RowIndex).InsertVisible = False AndAlso _

(row.RowState

And DataControlRowState.Insert) = DataControlRowState.Insert) Then

writer.WriteAttribute(

"style", "display:none;")

End If

Re: asp:DetailsView renders incorrectly with CSS friendly control adapter

bdemarzo — Tue, 01 May 2007 13:43:01 GMT

Feel free to document your proposed changes and post them on the CodePlex site so we can review and incorporate them.

Re: asp:DetailsView renders incorrectly with CSS friendly control adapter

cavyn — Tue, 01 May 2007 09:32:50 GMT

I've just got the control adapters and have noticed this code seems to have been added to the latest vers to handle rendering fields not set to visible. This is fine when using Fields ie

ControlAsDetailsView.Fields[row.RowIndex].Visible but if the rows are set to Visible = false then there also needs to be a check for ControlAsDetailsView.Rows[row.RowIndex].Visible

I like the adapter framework and hopefully the next iteration of asp.net controls will render nicer markup like this natively.

Re: asp:DetailsView renders incorrectly with CSS friendly control adapter

TPS — Fri, 14 Jul 2006 02:40:15 GMT

Hey Russ, I will post this in some other forums, but could you just check it out yourself. Dealing with the DetailsView control adapter, you could just remove a field and then update a record.

Lete me know if you wipe out data as well if you would.

Thanks

Re: asp:DetailsView renders incorrectly with CSS friendly control adapter

Russ Helfand — Fri, 14 Jul 2006 00:31:35 GMT

Interesting. Have you looked around on the web for more info on this problem? You might want to post this on another forum to see what folks say. Offhand I've not run into this myself so I'm not sure what to tell you right now.

Re: asp:DetailsView renders incorrectly with CSS friendly control adapter

TPS — Thu, 13 Jul 2006 21:43:45 GMT

Sorry Russ, I didn't mean to imply that if we used your new if statement that empty <li> were showing up.

Just scratch what I said in my last post.

By the way, I know this has nothing to do with your great control adapter, but could you tell me if I am loosing my mind on this DetailsView issue.

If you don't include a field from the datasource in the DetailsView, the existing data in that field will be wiped out after you edit that row in the DetailsView when it is bound to an ObjectDataSource.

Example:

Table fields: First, Last, Address, Payrate

Table row values: Bob, Schmo, 123 Main, 125

Edit row in DetailsView

First: Bob changes to Robert

Last: Schmo

Address: 123 Main

Click Update

Table Row values: Robert, Schmo, 123 Main, 0

----------------------------------------

It seems the DetailsView ObjectDataSource is generating a new object, populating the object and sending it back with the MyBizObj.Update. Which would send the PayRate field back as 0.

Instead it should Get the object from the DB, populate it with the DetailsView fields and send it back to the DB.

This is very easy to Reproduce.

We ended up wiping out lots of data because a form we were giving to a user didn't include 4 or 5 fields of sensitive data. All of the sensitive data is now gone for the rows that she edited.

Re: asp:DetailsView renders incorrectly with CSS friendly control adapter

Russ Helfand — Thu, 13 Jul 2006 19:08:46 GMT

Hi Terrence,

Hmmmm. I don't know why you are seeing empty <li> elements in your markup. The code shown above shouldn't result in that:

if ((!ControlAsDetailsView.AutoGenerateRows) &&
    ((row.RowState & DataControlRowState.Insert) == DataControlRowState.Insert) &&
    (!ControlAsDetailsView.Fields[row.RowIndex].InsertVisible))
{
    continue;
}

This should cause the entire <li>'s generation to be aborted if you are in insert mode but the field is marked as InsertVisible==false.

Did you put this immediately inside the foreach, before the <li> is spit out into the writer?

There is a small problem insofar as the calculation of odd/even rows as a result of potentially skipping some rows because of this new heuristic. I'll clean that up for the next rev.

And speaking of the next rev, all I can say is that it is definitely happening and won't be too long: a matter of a few weeks or a couple months, at most. Hang tight. It's like remodeling a house: you have to rip stuff up a bit before you put it back together into an improved state. We're not done cleaning up from some of the refactoring, etc.

Re: asp:DetailsView renders incorrectly with CSS friendly control adapter

TPS — Thu, 13 Jul 2006 03:43:19 GMT

Russ, I see what you mean about the InsertVisible.

I now see that the fields are not getting rendered if InsertVisible is false, but the <li> row is getting generated, so if I have 3 hidden fields I get 3 blank rows.

I know you are a busy man, but any idea when the next rev will be coming out? I love the controls.

Terrence

Re: asp:DetailsView renders incorrectly with CSS friendly control adapter

Russ Helfand — Mon, 10 Jul 2006 18:33:18 GMT

Hi Terrence, you asked in an earlier post (in this thread) if we ought to further modify the "if" expression to specifically cover the "view" and "edit" cases, beside the "insert" case. I think the answer is that we don't really need to. The property InsertVisible is rather unique. There is no counterpart to it. There is no EditVisible or ViewVisible property. So it seems like we really only need to handle InsertVisible when we are in insert mode. Otherwise, we can ignore it and don't have any other comparable attributes to worry about. I think the framework (deeper down) handles the case where Visible=false by not trying to do the render at all. Let me know if you seem to see evidence that that isn't so.

Now, regarding your other ideas:

Creating some additional themes is an interesting idea. Frankly, it would be a great way for some enterprising developer/designer to make some good money. Someone could start building themes that specifically work with the kit's adapters (together with skins that work when the adapters aren't being used... for old browsers, etc.). Maybe there is a market for such themes. Meanwhile, I'll keep your suggestion (free additional themes for the kit) in mind but I must admit that there's plenty of work "on the plate" having to do with extending the kit to cover more controls and more control properties (attributes). Ahhhhh, I had making choices like this!
Building a GridViewAdapter is already on my radar. In fact, I've already started the work. I intend to include it in the next rev of the kit.

Please keep providing feedback. It's very helpful. Best regards,

Re: asp:DetailsView renders incorrectly with CSS friendly control adapter

TPS — Sun, 09 Jul 2006 03:19:05 GMT

Hey Russ, on another note, have you guys:

1. Come up with anymore themes? I know we can come up with them, but I'm a data man and making sights look good is not my strong point.

2. Come up with a Control Adapter for the GridView?

Thanks again for the great tools you guys are coming up with.

Terrence

Re: asp:DetailsView renders incorrectly with CSS friendly control adapter

TPS — Sun, 09 Jul 2006 03:06:50 GMT

Hey Russ, that looks like it will work for Insert mode. But what about just plain old view mode when you are looking at a DetailsView. It seems that you are only accounting for Insert Mode.

I know my solution is short sighted because I don't have enough knowledge to think about rowstate and whether we are in insert mode or not, but now you have me thinking.

My solution does not account for the developer who purposely decides not to have a row HeaderText set.

But your "ControlAsDetailsView.Fields[row.RowIndex].InsertVisible" is what I was really looking for, so how about...

(psuedo code)

if ( (InsertMode & InsertVisible) || (EditMode & Visible) || (ViewMode & Visible) )

Doesn't that cover all the situations?

I guess you have the following statement include for performance because you would not be making this check if you were auto gening the rows.

((!ControlAsDetailsView.AutoGenerateRows

Thanks for you fast response Russ, I look forward to your response so I can put this bit of the site configuration to bed.

Terrence

Re: asp:DetailsView renders incorrectly with CSS friendly control adapter

Russ Helfand — Sun, 09 Jul 2006 00:24:09 GMT

Cool, TPS. Thanks for contributing that.

I ended up with a slightly different "if" expression:

I put this just inside the "foreach" statement you referred to (above). What do you think of this alternative?

Re: asp:DetailsView renders incorrectly with CSS friendly control adapter

TPS — Sat, 08 Jul 2006 23:28:45 GMT

Brian, here is a quick fix for the rows showing up that have been marked as visible.

Open up the DetailsViewAdapter.cs file and add this if statement after the foreach statement.

Rows that are marked as visible=false, the HeaderText value is " " So if it is not " " then it must be marked as visible.

foreach (DetailsViewRow row in ControlAsDetailsView.Rows)

{

if (row.Cells[0].Text != " ")

{

Re: asp:DetailsView renders incorrectly with CSS friendly control adapter

Russ Helfand — Mon, 15 May 2006 15:55:06 GMT

For those interested in simulating the original problem having to do with InsertVisible... go to DetailsViewExample.aspx and alter the DetailsView so it looks like this:

<asp:DetailsView ID="DetailsView1" Runat="server" DefaultMode="Insert" SkinID="SampleDetailsView" DataSourceID="AuthorsDS" AutoGenerateRows="False" HeaderText="Author Details" AllowPaging="True" CssSelectorClass="PrettyDetailsView" OnItemUpdated="FakeItemUpdate">

<asp:BoundField InsertVisible="False" HeaderText="ID" DataField="au_id" />

<asp:BoundField InsertVisible="False" HeaderText="Last name" DataField="au_lname" />

<asp:BoundField InsertVisible="False" HeaderText="First name" DataField="au_fname" />

<asp:BoundField InsertVisible="False" HeaderText="Phone" DataField="phone" />

<asp:BoundField InsertVisible="False" HeaderText="Street" DataField="address" />

<asp:BoundField InsertVisible="False" HeaderText="City" DataField="city" />

<asp:BoundField InsertVisible="False" HeaderText="State" DataField="state" />

<asp:BoundField HeaderText="ZIP code" DataField="zip" />

<asp:BoundField InsertVisible="False" HeaderText="Contract" DataField="contract" />

<asp:CommandField ShowInsertButton="True" />

</Fields>

</asp:DetailsView>

Run the page. Only the ZIP code line should show up because the other bound fields are explicitly marked with InsertVisible="False". That's the problem with the current implementation of the DetailsViewAdapter. I'm working on a fix...