Page view counter

Validators not Validating

Last post 09-28-2005 5:25 PM by PLBlum. 4 replies.

Sort Posts:

  • Validators not Validating

    09-22-2005, 12:45 PM
    • Loading...
    • JimAmigo
    • Joined on 01-28-2004, 1:40 PM
    • Posts 252
    • Points 581

    Would anyone know why the validations on the page below wouldn't work. I am going through a book and learning asp.net and for some reason when I put in the last subroutine to insert the record the validation checks on the controls on the form no longer work.



    <%@ Import Namespace="System.Data.SqlClient" %>
    <html>
    <head>
    <title>The Dorknozzle.com Intranet Site</title>
    <script runat="server" language="VB">
    Dim objConn As New SQLConnection("Server=XXXXXXX; database=Dorknozzle; uid=XXXXXXX; Pwd=XXXXXXXX;")
    Dim objCmd As SQLCommand
    Dim objRdr As SQLDataReader 

    Sub Page_Load()
     If Not IsPostBack Then
       objConn.Open()
      
     objCmd = New SQLCommand("Select * From HelpDeskCategories", objConn)
     objRdr = objCmd.ExecuteReader()
     ddlCategory.DataSource = objRdr
     ddlCategory.DataValueField = "CategoryID"
     ddlCategory.DataTextField = "Category"
     ddlCategory.DataBind() 
     objRdr.Close() 
     
     objCmd = New SQLCommand("Select * From HelpDeskSubjects", objConn)
     objRdr = objCmd.ExecuteReader()
     ddlSubject.DataSource = objRdr
     ddlSubject.DataValueField = "SubjectID"
     ddlSubject.DataTextField = "Subject"
     ddlSubject.DataBind() 
     objRdr.Close()  
     
     objConn.Close()
      End If
    End Sub

    Sub SubmitHelpDesk(s As Object, e As EventArgs)
        objCmd = New SQLCommand("INSERT INTO HelpDesk (EmployeeID, StationNumber, CategoryID, SubjectID, Description, StatusID)" & _
     "VALUES (@EmployeeID, @StationNumber, @CategoryID, @SubjectID, @Description, @StatusID)", objConn)
     objCmd.Parameters.Add("@EmployeeID", 5)
     objCmd.Parameters.Add("@StationNumber", txtStationNum.Text)
     objCmd.Parameters.Add("@CategoryID", ddlCategory.SelectedItem.Value)
     objCmd.Parameters.Add("@SubjectID", ddlSubject.SelectedItem.Value)
     objCmd.Parameters.Add("@Description", txtDescription.Text)
     objCmd.Parameters.Add("@StatusID", 1)
     objConn.Open()
     objCmd.ExecuteNonQuery()
     objConn.Close()
     Response.Redirect("helpdesk.aspx")
    End Sub
    </script>

    <link href="styles.css" rel="stylesheet" />
    </head>
    <body>
    <form runat="server">
    <table width="100%" border="0" cellspacing="0" cellpadding="0" background="Images/header_bg.gif">
     <tr>
      <td><img src="Images/header_top.gif" width="450" height="142" alt="dorknozzle.com: the official dorknozzle company intranet" /></td>
     </tr>
    </table>

    <table width="100%" border="0" cellspacing="0" cellpadding="0">
     <tr>
      <td width="157"><img src="Images/header_bottom.gif" width="157" height="37" alt="" /></td>
      <td></td>
     </tr>
    </table>

    <table width="100%" border="0" cellspacing="0" cellpadding="10">
     <tr>
      <td valign="top" width="160">
       <!-- HyperLink Controls for navigation -->
       <img src="Images/book_closed.gif" width="16" height="16" alt="+" /><asp:HyperLink NavigateUrl="index.aspx" runat="server" Text="Home" /><br />
       <img src="Images/book_closed.gif" width="16" height="16" alt="+" /><asp:HyperLink NavigateUrl="helpdesk.aspx" runat="server" Text="HelpDesk" /><br />
       <img src="Images/book_closed.gif" width="16" height="16" alt="+" /><asp:HyperLink NavigateUrl="employeestore.aspx" runat="server" Text="Employee Store" /><br />
       <img src="Images/book_closed.gif" width="16" height="16" alt="+" /><asp:HyperLink NavigateUrl="newsletterarchive.aspx" runat="server" Text="Newsletter Archive" /><br />
       <img src="Images/book_closed.gif" width="16" height="16" alt="+" /><asp:HyperLink NavigateUrl="employeedirectory.aspx" runat="server" Text="Employee Directory" /><br />
       <img src="Images/book_closed.gif" width="16" height="16" alt="+" /><asp:HyperLink NavigateUrl="addressbook.aspx" runat="server" Text="Address Book" /><br /><br />
       <img src="Images/book_closed.gif" width="16" height="16" alt="+" /><asp:HyperLink NavigateUrl="admintools.aspx" runat="server" Text="Admin Tools" />
       <!-- End HyperLink Controls -->
      </td>
      <td valign="top">
      <h1>Employee HelpDesk Request</h1>
       <p>Station Number:<br />
       <asp:TextBox id="txtStationNum" CssClass="textbox" runat="server" /><br />
        <asp:RequiredFieldValidator id="rfvStationNum" Display="Dynamic" ControlToValidate="txtStationNum" ErrorMessage="You must enter a station number!" runat="server" />
        <asp:CompareValidator id="cvStationNum" Display="Dynamic" ControlToValidate="txtStationNum" Operator="DataTypeCheck" Type="Integer" ErrorMessage="Station number must be a number!" runat="server" />
        <asp:RangeValidator id="rvStationNum" Display="Dynamic" ControlToValidate="txtStationNum" MinimumValue="1" MaximumValue="50" ErrorMessage="Number must be between 1 and 50" Type="Integer" runat="server" /></p>
       <p>Problem Category:<br />
        <asp:DropDownList id="ddlCategory" CssClass="dropdownmenu" runat="server" /></p>
         <p>Problem Subject:<br />
        <asp:DropDownList id="ddlSubject" CssClass="dropdownmenu" runat="server" /></p>
         <p>Problem Description:<br />
        <asp:TextBox id="txtDescription" CssClass="textbox" Columns="40" Rows="4" TextMode="MultiLine" runat="server" /><br />
         <asp:RequiredFieldValidator id="rfvDescription" Display="Dynamic" ControlToValidate="txtDescription" ErrorMessage="You must enter a description of the problem!" runat="server" /></p>
          <asp:Button id="btnSubmit" CssClass="button" Text="Submit Request" onClick="SubmitHelpDesk" runat="server" /></p>
        <asp:ValidationSummary id="vsSummary" ShowMessageBox="true" ShowSummary="false" runat="server" />
      </td>
     </tr>
    </table>

    </form>
    </body>
    </html>

    Jim
  • Re: Validators not Validating

    09-23-2005, 8:07 AM
    • Loading...
    • WimH
    • Joined on 09-04-2005, 11:05 AM
    • UK
    • Posts 301
    • Points 1,577
    Surround the code in your SubmitHelpdesks routine with:

    If IsValid
    ....
    End If


    It might be that the client side validation isn't working because the validator controls don't render client script for the specific browser (I've seen this happen on certain FireFox versions).

    So checking the Page's IsValid property is always recommended practice.

    Cheers,
    Wim

    Wim Hollebrandse
    ---
    http://www.zealandit.com
  • Re: Validators not Validating

    09-23-2005, 8:30 AM
    • Loading...
    • fadil1977
    • Joined on 08-23-2004, 12:43 AM
    • london
    • Posts 1,581
    • Points 7,894
    Fadil Alnassar
    www.fadilalnassar.com | FREE Nodil Tab Control
    http://www.mefranchising.com
  • Re: Validators not Validating

    09-28-2005, 12:07 PM
    • Loading...
    • JimAmigo
    • Joined on 01-28-2004, 1:40 PM
    • Posts 252
    • Points 581
    I changed the code as requested... and it is working as should now. Could you explain why it didn't work as explained in the book I am using for learning. Just hoping to learn more.

    Thanks for all your help!
    Jim
  • Re: Validators not Validating

    09-28-2005, 5:25 PM
    • Loading...
    • PLBlum
    • Joined on 06-28-2002, 9:20 AM
    • Boston, MA
    • Posts 5,308
    • Points 30,007
    I wrote an article on this and many other issues with validation: www.aspalliance.com/699.
    --- Peter Blum
    Creator of Peter's Data Entry Suite (formerly Professional Validation And More and Peter's Date Package) and Peter's Polling Package
    www.PeterBlum.com
Page 1 of 1 (5 items)