Im using this code, i want to know is it the best way to insert data into a db and do i miss something so its running better !?
Protected Sub btnSave_Click(ByVal sender As Object, ByVal e As System.EventArgs)
Dim strSQL As String = ""
strSQL = "" & _
"INSERT INTO news_users " & _
"(newsuser_name, newsuser_mail, newsuser_gen, newsuser_dob, newsuser_status, newsuser_add, newsuser_city, newsuser_zip) " & _
"VALUES (?,?,?,?,?,?,?,?)"
Using connection As OleDbConnection = New OleDbConnection(ConfigurationManager.ConnectionStrings("MasterConnStr").ConnectionString)
Using insertcmd As OleDbCommand = New OleDbCommand(strSQL, connection)
insertcmd.CommandType = CommandType.Text
insertcmd.Parameters.AddWithValue("newsuser_name", addedmailnametext.Text)
insertcmd.Parameters.AddWithValue("newsuser_mail", addedemailtext.Text)
insertcmd.Parameters.AddWithValue("newsuser_gen", gen.Text)
insertcmd.Parameters.AddWithValue("newsuser_dob", dobd.Text - dobm.Text - doby.Text)
insertcmd.Parameters.AddWithValue("newsuser_status", 0)
insertcmd.Parameters.AddWithValue("newsuser_add", Now.ToShortDateString)
insertcmd.Parameters.AddWithValue("newsuser_city", addedmailcitytext.Text)
insertcmd.Parameters.AddWithValue("newsuser_zip", addedmailzip.Text)
insertcmd.Connection.Open()
insertcmd.ExecuteNonQuery()
End Using
End Using
End Sub
Yes - you appear to be following best practices. You are ensuring that your connection is closed and disposed with the Using statement, and you are using parameters to protect against SQL protection.
One change - I would use the Date() function in Access to generate the current date instead of doing it in VB.
siraero
Member
419 Points
608 Posts
Is this the best way to use Intert Into.
Apr 29, 2012 06:43 PM|LINK
Hi.
Im using this code, i want to know is it the best way to insert data into a db and do i miss something so its running better !?
Protected Sub btnSave_Click(ByVal sender As Object, ByVal e As System.EventArgs) Dim strSQL As String = "" strSQL = "" & _ "INSERT INTO news_users " & _ "(newsuser_name, newsuser_mail, newsuser_gen, newsuser_dob, newsuser_status, newsuser_add, newsuser_city, newsuser_zip) " & _ "VALUES (?,?,?,?,?,?,?,?)" Using connection As OleDbConnection = New OleDbConnection(ConfigurationManager.ConnectionStrings("MasterConnStr").ConnectionString) Using insertcmd As OleDbCommand = New OleDbCommand(strSQL, connection) insertcmd.CommandType = CommandType.Text insertcmd.Parameters.AddWithValue("newsuser_name", addedmailnametext.Text) insertcmd.Parameters.AddWithValue("newsuser_mail", addedemailtext.Text) insertcmd.Parameters.AddWithValue("newsuser_gen", gen.Text) insertcmd.Parameters.AddWithValue("newsuser_dob", dobd.Text - dobm.Text - doby.Text) insertcmd.Parameters.AddWithValue("newsuser_status", 0) insertcmd.Parameters.AddWithValue("newsuser_add", Now.ToShortDateString) insertcmd.Parameters.AddWithValue("newsuser_city", addedmailcitytext.Text) insertcmd.Parameters.AddWithValue("newsuser_zip", addedmailzip.Text) insertcmd.Connection.Open() insertcmd.ExecuteNonQuery() End Using End Using End Subsunilgurjar
Contributor
2252 Points
478 Posts
Re: Is this the best way to use Intert Into.
Apr 30, 2012 04:15 AM|LINK
if you want to insert one record then your code is well
but if u want to insert multipal record at a time then you use bulk insert statement
read my blog
http://sunilgurjar.blogspot.com/
Mikesdotnett...
All-Star
155599 Points
19982 Posts
Moderator
MVP
Re: Is this the best way to use Intert Into.
Apr 30, 2012 05:15 AM|LINK
Yes - you appear to be following best practices. You are ensuring that your connection is closed and disposed with the Using statement, and you are using parameters to protect against SQL protection.
One change - I would use the Date() function in Access to generate the current date instead of doing it in VB.
Web Pages CMS | My Site | Twitter