Hi Guys, 

 Have written a Sub to update my user roles. The gvMembers refers to the Username taken from a a gridview used to select the user, cblRoles is a CheckBoxList which show all available roles and rolebox refers to the ListItems which create the checkboxes. However for some reason it does not recognise the checkboxes as being checked. Tried putting a breakpoint in the Else part of the code and every checked box hit it including the ones I had checked. Code follows:

Private Sub UpdateUserRoles()

        For Each rolebox As ListItem In cblRoles.Items
            If rolebox.Selected Then
                If Roles.IsUserInRole(gvMembers.SelectedValue, rolebox.Text) = False Then
                    Roles.AddUsersToRole(gvMembers.SelectedValue, rolebox.Text)
                End If
            Else
                If Roles.IsUserInRole(gvMembers.SelectedValue, rolebox.Text) Then
                    Roles.RemoveUserFromRole(gvMembers.SelectedValue, rolebox.Text)
                End If
            End If
        Next

    End Sub

 Any ideas why it's not working?
 

Hi,

Post your HTML please and check is your checkbox has the property AutoPostBack set to true.

 HTML is simply:

                        <asp:CheckBoxList ID="cblRoles" runat="server">
                        </asp:CheckBoxList>

The checkboxlist is populated by: 

   cblRoles.DataSource = Roles.GetAllRoles()
        cblRoles.DataBind()

            For Each checkbox As ListItem In cblRoles.Items
                checkbox.Enabled = False
        Next

        Dim userRoles As String() = Roles.GetRolesForUser(gvMembers.SelectedValue)
        For Each role As String In userRoles
            Dim checkbox As ListItem = cblRoles.Items.FindByValue(role)
            checkbox.Selected = True
        Next
 

Here is my idea to solve your problem

first thing you will get role that user assigned to him and second check if user role match what he select show him that he is already in that role

but if user not assigned to selected role from CheckBoxList you will delete user from role and add him to role that he selected from CheckBoxList

Hope that i could help you

Unless you set your CheckBox list like this:  

<asp:CheckBoxList ID="CheckBoxList1" runat="server" AutoPostBack="True">
    </asp:CheckBoxList>

 Autopost back doesn't work. The page just post back and clears the check box again.

 Have tried giving each role their own individual check box rather than a check box list and given each one the following code (obviously with different control names).

        If ChkAdmin.Checked = True Then
            If Roles.IsUserInRole(gvMembers.SelectedValue, ChkAdmin.Text) = False Then
                Roles.AddUsersToRole(gvMembers.SelectedValue, ChkAdmin.Text)
            End If
        Else
            If Roles.IsUserInRole(gvMembers.SelectedValue, ChkAdmin.Text) Then
                Roles.RemoveUserFromRole(gvMembers.SelectedValue, ChkAdmin.Text)
            End If
        End If

Now when I click update I get the following error in the error textBox on my page rather than the dreaded ASP.NET error page: 

Update Failed: Unable to cast object of type 'System.String' to type 'System.String[]'. 

Any ideas? If anyone can figure the problem with my first way doing it that would be even better. 

Do you put your code to load the checkboxes in the page_load event? If so are you wrapping your code in: 

If not Page.IsPostBack then

...Code here

End If