A bug and a minor niggle. RSS

• • Reply
  

  RRidge

  Member

  76 Points

  20 Posts

  A bug and a minor niggle.

  Dec 12, 2007 01:04 AM|LINK

   Firstly, is there an appropriate place to file bugs?  Offhand, I didn't see anything on connect, nor have I seen mention of such a place in any of the release posts.  Is this really the preferred place for such feedback?

   The first issue I came to today was that a null reference exception is thrown if you have session state disabled:

   [NullReferenceException: Object reference not set to an instance of an object.]
  

  System.Web.HttpSessionStateWrapper.System.Web.IHttpSessionState.get_Item(String name) +5
     System.Web.Mvc.TempDataDictionary.EnsureReadData() +106
     System.Web.Mvc.Controller.Execute(ControllerContext controllerContext) +90
     System.Web.Mvc.Controller.System.Web.Mvc.IController.Execute(ControllerContext controllerContext) +4
     System.Web.Mvc.MvcHandler.ProcessRequest(IHttpContext httpContext) +168
     System.Web.Mvc.MvcHandler.ProcessRequest(HttpContext httpContext) +32
     System.Web.Mvc.MvcHandler.System.Web.IHttpHandler.ProcessRequest(HttpContext httpContext) +4
     System.Web.CallHandlerExecutionStep.System.Web.HttpApplication.IExecutionStep.Execute() +358
     System.Web.HttpApplication.ExecuteStep(IExecutionStep step, Boolean& completedSynchronously) +64

  The second, much more minor niggle, was that  

  Html.Form<T>(action => action.Foo)

   produces:

   <form action="/Home" method=post >

   Note missing quotes on the method and extraneous space before the tag end.  I'm sure valid HTML is on your radar, but I came across it and figured I'd point it out.   I also might like to have Url.Action<T> such that I can do: 

   <form action="<%=Url.Action<T>(action => action.Foo)%>">

  Similarly, I could see some other methods crying out for some typesafe love, like Controller.RedirectToAction<T>, etc. 

    
  • Edited by RRidge on Dec 12, 2007 02:08 AM
  • Edited by RRidge on Dec 12, 2007 02:10 AM
  • Edited by RRidge on Dec 12, 2007 02:54 AM
• • Reply
  

  robconery

  Participant

  852 Points

  195 Posts

  Re: A bug and a minor niggle.

  Dec 12, 2007 03:33 AM|LINK

   Thanks RRidge - I was just working with Damien Guard today (who I think goes by "Mr. HTML") and I worked on a number of validation issues - the post tag being one of them. I'll punt the Session issue to Phil - but I'm pretty sure that's on his radar.
  

• • Reply
  

  Haacked

  Contributor

  6901 Points

  412 Posts

  Re: A bug and a minor niggle.

  Dec 12, 2007 05:46 AM|LINK

  This is a great place to report a bug. Thanks! It's on our radar.

  Phil Haack (http://haacked.com/)
  Senior Program Manager, Microsoft
  
  What wouldn’t you do for a Klondike bar?
  • Marked as answer by Haacked on Dec 12, 2007 05:46 AM